Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Delivering the MVP Applying a Discount Code

Not sure why this code is not working?

I am not sure why this code is not working!

Order.java
public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  private String normalizeDiscountCode(String discountCode) {
    String discount = discountCode.toUpperCase();
    for (char letter : discountCode.toCharArray()){
    if (!Character.isLetter(letter) || letter != '$')
    {
    throw new IllegalArgumentException("Invalid discount code.") ;  
    }
    }

    return discount;

  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return discountCode;
  }

  public void applyDiscountCode(String discountCode) {

    this.discountCode = normalizeDiscountCode(discountCode);

  }   
}
Example.java
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

1 Answer

Yanuar Prakoso
Yanuar Prakoso
15,196 Points

Hi there Harihar Kandula I try to modify your code and tried it in the challenge and it works. Here is my code:

 public void applyDiscountCode(String discountCode) {
    this.discountCode = normalizeDiscountCode(discountCode);
  }

  private String normalizeDiscountCode(String discountCode) {
    for (char letter : discountCode.toCharArray()){
      if (!(Character.isLetter(letter) || letter == '$')){ //this is what you should use instead negating the statements one by one
        throw new IllegalArgumentException("Invalid discount code.");
      }
    }
    return discountCode.toUpperCase();
  }

When I first use your code I got warning that the first code in the answer is not passing. The main problem is your logical expression inside the if statement. The request was if the discount code does NOT consist (letters OR '$') thus you should write it as !(Character.isLetter(letter) || '$').

the way you wrote the logical expression:

for (char letter : discountCode.toCharArray()){
    if (!Character.isLetter(letter) || letter != '$')
    {
    throw new IllegalArgumentException("Invalid discount code.") ;  
    }

If you still insist to use your original pattern of code the logical expression should be if(!Character.isLetter(letter) && letter != '$'). I already try it also and it works. Here is the modified part of the code I built:

 public void applyDiscountCode(String discountCode) {
    this.discountCode = normalizeDiscountCode(discountCode);
  }

  private String normalizeDiscountCode(String discountCode) {
    String discount = discountCode.toUpperCase();
    for (char letter : discountCode.toCharArray()){
    if (!Character.isLetter(letter) && letter != '$')
    {
    throw new IllegalArgumentException("Invalid discount code.") ;  
    }
    }

    return discount;
  }

For more information about logical expression (if you still wondering why your logical expression is wrong) you can search more online I guess. I hope this may help you pass the challenge.