Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community!

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Write Better Python Buggy Logs Logging

drew s
.a{fill-rule:evenodd;}techdegree seal-36
drew s
Python Development Techdegree Graduate 19,491 Points

Not working

I copied exact same code but I got different result after running the program. I notice his X disappeared while mine still there.

Here is my code:

import logging
import random

logging.basicConfig(filename='game.log', level=logging.DEBUG)

player = {'location': None, 'path': []}
cells = [(0, 0), (0, 1), (0, 2),
         (1, 0), (1, 1), (1, 2),
         (2, 0), (2, 1), (2, 2)]

def get_locations():
    monster = random.choice(cells)
    door = random.choice(cells)
    start = random.choice(cells)

    if monster == door or monster == start or door == start:
        monster, door, start = get_locations()

    return monster, door, start

def get_moves(player):
    moves = ['LEFT', 'RIGHT', 'UP', 'DOWN']
    if player in [(0, 0), (1, 0), (2, 0)]:
    if player in [(0, 0), (0, 1), (0, 2)]:
    if player in [(0, 2), (1, 2), (2, 2)]:
    if player in [(2, 0), (2, 1), (2, 2)]:
    return moves

def move_player(player, move):
    x, y = player['location']
    player['path'].append((x, y))
    if move == 'LEFT':
        player['location'] = x, y - 1
    elif move == 'UP':
        player['location'] = x - 1, y
    elif move == 'RIGHT':
        player['location'] = x, y + 1
    elif move == 'DOWN':
        player['location'] = x + 1, y
    return player

def draw_map():
    print(' _ _ _')
    tile = '|{}'
    for idx, cell in enumerate(cells):
        if idx in [0, 1, 3, 4, 6, 7]:
            if cell == player['location']:
                print(tile.format('X'), end='')
            elif cell in player['path']:
                print(tile.format('.'), end='')
                print(tile.format('_'), end='')
            if cell == player['location']:
            elif cell in player['path']:

monster, door, player['location'] = get_locations()
logging.info('monster: {}; door: {}; player: {}'.format(
        monster, door, player['location']))

while True:
    moves = get_moves(player['location'])
    print("Welcome to the dungeon!")
    print("You're currently in room {}".format(player['location']))


    print("\nYou can move {}".format(', '.join(moves)))
    print("Enter QUIT to quit")

    move = input("> ")
    move = move.upper()

    if move == 'QUIT':

    if not move in moves:
        print("\n** Walls are hard! Stop running into them! **\n")

    player = move_player(player, move)
    if player['location'] == door:
        print("\n** You escaped! **\n")
    elif player['location'] == monster:
        print("\n** You got eaten! **\n")

2 Answers

Steven Parker
Steven Parker
228,039 Points

This code performs as expected for me. The "X" moves to the new location and is replaced by a blank (and a dot) in the previous location.

Chris Freeman
Chris Freeman
Treehouse Moderator 68,404 Points

Great question!! On first glance I’m wondering why Kenneth’s code doesn’t produce an “X”. And I've finally figured it out.

In the video code, there is a bug in the draw_map function. The blocks of code under the ifand else sections are not the same. The if block uses:

if cell == player['location']:

the else block uses:

if cell == player:

The latter comparison will always fail because cell is a tuple and player is a dict.

In copying the code, you used the correct comparison to player['location'].

Post back if you have more questions. Good luck!!