Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Android

Josh Gold
Josh Gold
12,207 Points

Null Pointer Exception for Stormy App when I press 7 Day Button

Error: java.lang.NullPointerException at teamtreehouse.com.stormy.ui.MainActivity.startDailyActivity(MainActivity.java:205)

Here are lines 202 through 208 of MainActivity.java:

     @Override
     protected void onCreate(Bundle savedInstanceState) {
          super.onCreate(savedInstanceState);
          setContentView(R.layout.activity_daily_forecast);

          Intent intent = getIntent();
          Parcelable[] parcelables = intent.getParcelableArrayExtra(MainActivity.DAILY_FORECAST);
          mDays = Arrays.copyOf(parcelables, parcelables.length, Day[].class);

          DayAdapter adapter = new DayAdapter(this, mDays);
     }

Complete MainActivity.java file

     package teamtreehouse.com.stormy.ui;

     import android.content.Context;
     import android.content.Intent;
     import android.graphics.drawable.Drawable;
     import android.net.ConnectivityManager;
     import android.net.NetworkInfo;
     import android.os.Bundle;
     import android.support.v7.app.ActionBarActivity;
     import android.util.Log;
     import android.view.View;
     import android.widget.ImageView;
     import android.widget.ProgressBar;
     import android.widget.TextView;
     import android.widget.Toast;

     import com.squareup.okhttp.Call;
     import com.squareup.okhttp.Callback;
     import com.squareup.okhttp.OkHttpClient;
     import com.squareup.okhttp.Request;
     import com.squareup.okhttp.Response;

     import org.json.JSONException;
     import org.json.JSONObject;

     import java.io.IOException;

     import butterknife.ButterKnife;
     import butterknife.InjectView;
     import butterknife.OnClick;
     import teamtreehouse.com.stormy.R;
     import teamtreehouse.com.stormy.weather.Current;
     import teamtreehouse.com.stormy.weather.Forecast;


     public class MainActivity extends ActionBarActivity {

         public static final String TAG = MainActivity.class.getSimpleName();
         public static final String DAILY_FORECAST = "DAILY FORECAST";

    private Forecast mForecast;
    private Current mCurrent;

    @InjectView(R.id.timeLabel) TextView mTimeLabel;
    @InjectView(R.id.temperatureLabel) TextView mTemperatureLabel;
    @InjectView(R.id.humidityValue) TextView mHumidityValue;
    @InjectView(R.id.precipValue) TextView mPrecipValue;
    @InjectView(R.id.summaryLabel) TextView mSummaryLabel;
    @InjectView(R.id.iconImageView) ImageView mIconImageView;
    @InjectView(R.id.refreshImageView) ImageView mRefreshImageView;
    @InjectView(R.id.progressBar) ProgressBar mProgressBar;

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);
        ButterKnife.inject(this);

        mProgressBar.setVisibility(View.INVISIBLE);

        final double latitude = 37.8267;
        final double longitude = -122.423;

        mRefreshImageView.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {
                getForecast(latitude, longitude);
            }
        });

        getForecast(latitude, longitude);

        Log.d(TAG, "Main UI code is running!");
    }

    private void getForecast(double latitude, double longitude) {
        String apiKey = "27974c4bc33201748eaf542a6769c3b7";
        String forecastUrl = "https://api.forecast.io/forecast/" + apiKey +
                "/" + latitude + "," + longitude;

        if (isNetworkAvailable()) {
            toggleRefresh();

            OkHttpClient client = new OkHttpClient();
            Request request = new Request.Builder()
                    .url(forecastUrl)
                    .build();

            Call call = client.newCall(request);
            call.enqueue(new Callback() {
                @Override
                public void onFailure(Request request, IOException e) {
                    runOnUiThread(new Runnable() {
                        @Override
                        public void run() {
                            toggleRefresh();
                        }
                    });
                    alertUserAboutError();
                }

                @Override
                public void onResponse(Response response) throws IOException {
                    runOnUiThread(new Runnable() {
                        @Override
                        public void run() {
                            toggleRefresh();
                        }
                    });

                    try {
                        String jsonData = response.body().string();
                        Log.v(TAG, jsonData);
                        if (response.isSuccessful()) {
                            mCurrent = getCurrentDetails(jsonData);
                            runOnUiThread(new Runnable() {
                                @Override
                                public void run() {
                                    updateDisplay();
                                }
                            });
                        } else {
                            alertUserAboutError();
                        }
                    }
                    catch (IOException e) {
                        Log.e(TAG, "Exception caught: ", e);
                    }
                    catch (JSONException e) {
                        Log.e(TAG, "Exception caught: ", e);
                    }
                }
            });
        }
        else {
            Toast.makeText(this, getString(R.string.network_unavailable_message),
                    Toast.LENGTH_LONG).show();
        }
    }

    private void toggleRefresh() {
        if (mProgressBar.getVisibility() == View.INVISIBLE) {
            mProgressBar.setVisibility(View.VISIBLE);
            mRefreshImageView.setVisibility(View.INVISIBLE);
        }
        else {
            mProgressBar.setVisibility(View.INVISIBLE);
            mRefreshImageView.setVisibility(View.VISIBLE);
        }
    }

    private void updateDisplay() {
        mTemperatureLabel.setText(mCurrent.getTemperature() + "");
        mTimeLabel.setText("At " + mCurrent.getFormattedTime() + " it will be");
        mHumidityValue.setText(mCurrent.getHumidity() + "");
        mPrecipValue.setText(mCurrent.getPrecipChance() + "%");
        mSummaryLabel.setText(mCurrent.getSummary());

        Drawable drawable = getResources().getDrawable(mCurrent.getIconId());
        mIconImageView.setImageDrawable(drawable);
    }

    private Current getCurrentDetails(String jsonData) throws JSONException {
        JSONObject forecast = new JSONObject(jsonData);
        String timezone = forecast.getString("timezone");
        Log.i(TAG, "From JSON: " + timezone);

        JSONObject currently = forecast.getJSONObject("currently");

        Current current = new Current();
        current.setHumidity(currently.getDouble("humidity"));
        current.setTime(currently.getLong("time"));
        current.setIcon(currently.getString("icon"));
        current.setPrecipChance(currently.getDouble("precipProbability"));
        current.setSummary(currently.getString("summary"));
        current.setTemperature(currently.getDouble("temperature"));
        current.setTimeZone(timezone);

        Log.d(TAG, current.getFormattedTime());

        return current;
    }


    private boolean isNetworkAvailable() {
        ConnectivityManager manager = (ConnectivityManager)
                getSystemService(Context.CONNECTIVITY_SERVICE);
        NetworkInfo networkInfo = manager.getActiveNetworkInfo();
        boolean isAvailable = false;
        if (networkInfo != null && networkInfo.isConnected()) {
            isAvailable = true;
        }

        return isAvailable;
    }

    private void alertUserAboutError() {
        AlertDialogFragment dialog = new AlertDialogFragment();
        dialog.show(getFragmentManager(), "error_dialog");
    }

    @OnClick(R.id.dailyButton)
    public void startDailyActivity(View view){
        Intent intent = new Intent(this, DailyForecastActivity.class);
        intent.putExtra(DAILY_FORECAST, mForecast.getDailyForeCast());
        startActivity(intent);

         }
     }

DailyForecastActivity.java

     package teamtreehouse.com.stormy.ui;

     import android.app.ListActivity;
     import android.content.Intent;
     import android.os.Bundle;
     import android.os.Parcelable;

     import java.util.Arrays;

     import teamtreehouse.com.stormy.R;
     import teamtreehouse.com.stormy.adapters.DayAdapter;
     import teamtreehouse.com.stormy.weather.Day;

     public class DailyForecastActivity extends ListActivity {

         private Day[] mDays;

         @Override
         protected void onCreate(Bundle savedInstanceState) {
             super.onCreate(savedInstanceState);
             setContentView(R.layout.activity_daily_forecast);

             Intent intent = getIntent();
             Parcelable[] parcelables = intent.getParcelableArrayExtra(MainActivity.DAILY_FORECAST);
             mDays = Arrays.copyOf(parcelables, parcelables.length, Day[].class);

             DayAdapter adapter = new DayAdapter(this, mDays);
         }
     }

1 Answer

Hello,

You are getting this error because in the following code:

    @OnClick(R.id.dailyButton)
    public void startDailyActivity(View view){
        Intent intent = new Intent(this, DailyForecastActivity.class);
        intent.putExtra(DAILY_FORECAST, mForecast.getDailyForeCast());
        startActivity(intent);

      }

mForcast is not assigned any values and thus is null so you are trying to call a method on a null object and thus getting the exception.

Josh Gold
Josh Gold
12,207 Points

As soon as I turned off my computer I realized I could just run the debugger and find out which variable(s) are null. Anyhow thanks James, you were correct.