Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

Android Build a Simple Android App (2014) Coding the Fun Facts Using Conditionals (else Statements)

only ants fact shows up. rest is blank

so whats happening is before i did this, i saw that when i pressed show me another fact, numbers werent showing up. so now that i did this if, else, its not working because of it.

package com.apps.tegh.funfacts;

import android.app.Activity;
import android.support.v7.app.ActionBarActivity;
import android.os.Bundle;
import android.view.Menu;
import android.view.MenuItem;
import android.view.View;
import android.widget.Button;
import android.widget.TextView;

import java.util.Random;


public class MainActivity extends Activity {

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);
        // Declare our View variables and assign the views from the layout file
        final TextView factLabel = (TextView) findViewById(R.id.factTextView);
        Button showFactButton = (Button)findViewById(R.id.showFactButton);

        View.OnClickListener listener = new View.OnClickListener() {
            @Override
            public void onClick(View view) {
                //The button was clicked so update the fact label with a new fact
                String fact;
                //randomly select fact
                Random randomGenerator = new Random();
                int randomNumber = randomGenerator.nextInt(3);
                 if (randomNumber == 0) {
                    fact = "Ants stretch when they wake up in the morning. ";
                 }
                 else if (randomNumber == 1) {
                    fact = "Ostriches can run faster than horses. ";
                }
                 else if (randomNumber == 2) {
                    fact = "Olympic gold medals are actually made mostly of silver. ";
                } else {
                     fact = "Sorry there was an error";
                 }






                //Update the label with our dynamic fact
                factLabel.setText(fact = "");
            }
        };
        showFactButton.setOnClickListener(listener);
    }

    @Override
    public boolean onCreateOptionsMenu(Menu menu) {
        // Inflate the menu; this adds items to the action bar if it is present.
        getMenuInflater().inflate(R.menu.menu_main, menu);
        return true;
    }

    @Override
    public boolean onOptionsItemSelected(MenuItem item) {
        // Handle action bar item clicks here. The action bar will
        // automatically handle clicks on the Home/Up button, so long
        // as you specify a parent activity in AndroidManifest.xml.
        int id = item.getItemId();

        //noinspection SimplifiableIfStatement
        if (id == R.id.action_settings) {
            return true;
        }

        return super.onOptionsItemSelected(item);
    } 

2 Answers

Seth Kroger
Seth Kroger
56,406 Points

The problem is the line: factLabel.setText(fact = ""); The fact = "" part sets fact to a blank string before calling setText().

Seth Kroger ok but how should I fix it

Seth Kroger
Seth Kroger
56,406 Points

factLabel.setText(fact);

Seth Kroger thanks it worked.

Jeanne Merle
Jeanne Merle
3,390 Points

You also can put it into comments : // factLabel.setText(fact);