OOJS Prototypal Inheritance Code Challenge Question 1

Question

I am wondering if the challenge itself if broken. I input my code and I am returned an error " Bummer! You don't need to set the firstName or lastName properties, the Person.call will handle that!" If I take all the properties out I get this error " Bummer! The Person.call method needs this, firstName and lastName, in that order!".
This code challenge is giving me mixed signals!
HELP!
```person.js
function Person(firstName, lastName) {
  this.firstName = firstName;
  this.lastName = lastName;
}
Person.prototype.fullName = function() {
 return this.firstName + " " + this.lastName; 
};
```
```teacher.js
function Teacher(firstName, lastName, roomNumber) {
  Person.call(this, firstName, lastName);
  this.firstName = firstName;
  this.lastName = lastName;
  this.room = roomNumber;
}
Teacher.prototype = Object.create(Person.prototype);
```

Eric Moody · Accepted Answer

Good work so far, but the challenge is asking you to remove the redundant code. 
function Teacher(firstName, lastName, roomNumber) {
  Person.call(this, firstName, lastName);
  this.firstName = firstName;
  this.lastName = lastName;
  this.room = roomNumber;
}
Your function is calling the this.firstName = firstName and the this.lastName = lastName from the person function already when you included the Person.call(this, firstName, lastName);
Just delete the this.first and this.last in order to make it pass. Like this. 
function Teacher(firstName, lastName, roomNumber) {
  Person.call(this, firstName, lastName);
  this.room = roomNumber;
}
Happy coding!

Welcome to the Treehouse Community

Looking to learn something new?

Mark Mueller

Mark Mueller

OOJS Prototypal Inheritance Code Challenge Question 1

1 Answer

Eric Moody

Eric Moody

Mark Mueller

Mark Mueller