Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trial
SUDHARSAN CHAKRAVARTHI
Courses Plus Student 2,434 PointsOOPS
Is there any thing wrong in my rage method declaration. ?.
from character import Character
class Warrior(Character):
weapon = 'sword'
def rage(self):
attack_limit = 20
3 Answers
William Li
Courses Plus Student 26,868 PointsDave Campbell , the indentation is okay here; in Python, as long as the indentation level and tab width is consistent, code will run.
and SUDHARSAN CHAKRAVARTHI the problem of your code is that
Make a new Warrior method called rage that sets attack_limit to 20.
attack_limit is an attribute in the class, you need to refer to it as self.attack_limit.
from character import Character
class Warrior(Character):
weapon = 'sword'
def rage(self):
self.attack_limit = 20
Chris Freeman
Treehouse Moderator 68,454 PointsI would argue that while the indention is not syntactically wrong, it is hardly "OK". -1 for condoning 2-spaces.
- Please take the Treehouse Challenge on Python Indentation in the Write Better Python course. You will learn that 4-spaces is the preferred style for readability.
- Please read PEP 8 on Indentation which says: Use 4 spaces per indentation level. Period.
- Please run
pylinton this code. You get the warning:Bad indentation. Found 2 spaces, expected 4 (bad-indentation)
Vittorio Somaschini
33,371 PointsWell I can only agree 4 is the standard for indentation, but all python code challenges here I think have 2 as indentation default.
I have always used that default (I think) for code challenges, while I try to stick to 4 in general and also workspaces.
For this specific case I said indentation was not a problem as it is NOT what is preventing him from passing the code challenge. I thought (and stil l think) that the other mistake really needed to be underlined instead.
;) Vittorio
William Li
Courses Plus Student 26,868 PointsHi there, chris freeman , yeah I agree with you too on the 4 spaces indentation; and Vittorio Somaschini 's comment is pretty much everything I wanna say, there's only 1 thing I want to add.
The bigger problem is why the challenges have a default spacing of 2-spaces
In some newer Python courses, (database course, for example), the Code challenges are indented using 4 spaces, I'm not sure why the codes in older courses were still having 2 spaces indentation as default; maybe it's too time-consuming to go back and redo the indentation for every Code challenges? I don't know.
SUDHARSAN CHAKRAVARTHI
Courses Plus Student 2,434 PointsThank you very much. it worked.
SUDHARSAN CHAKRAVARTHI
Courses Plus Student 2,434 PointsThank you very much. it worked.
Dave Campbell
13,310 PointsIf you wrote it here the same way it is in your code, you might need to correct the indentation.
Otherwise, double check to make sure you are providing a variable when you call the function.
Chris Freeman
Treehouse Moderator 68,454 PointsWhy was this down graded without commend. Rude. While this answer didn't completely solve the issue, was it voted down because of the indention comment? +1 for indention support!
Vittorio Somaschini
33,371 PointsHello Sudharsan.
I think your indentation is fine, as being a method I think is it ok.
The problem I see here is that you did not put the attack_limit=20 actually to that self, so it does not change the attack_limit.
You simply need to add self. right before attack_limit =20 resulting in
self.attack_method = 20
I hope I made it clear ;)
Vittorio
Chris Freeman
Treehouse Moderator 68,454 PointsYou had different indention advice on this question. The challenge wants 4-spaces because it Treehouse is trying to teach a better style not just "OK".
Vittorio Somaschini
33,371 PointsThat particular challenge asks for changing indentation...
Anyway, I agree with you Chris: 4 spaces indentation is surely better, but I thought it was not the main problem here.
It is really as simple as that.
Chris Freeman
Treehouse Moderator 68,454 PointsI'm glad that you agree with the 4-space indent.
Perhaps the better wording would have been "The indentation is not causing the problem". With a comment that 4-space indent is the norm.
The bigger problem is why the challenges have a default spacing of 2-spaces. It reinforces bad habits. In Workspaces, you can change the default from 2- to 4-spaces, but not in the challenges.
SUDHARSAN CHAKRAVARTHI
Courses Plus Student 2,434 PointsHello Vittorio Somaschini. Thank You very much. Yes. You are right. I understood.
Chris Freeman
Treehouse Moderator 68,454 PointsChris Freeman
Treehouse Moderator 68,454 PointsWhile monitors are stating the indention OK (I hope meaning it is not the root cause of the issue), Please get in the habit of using 4-space indentation (and not a TAB).
pylint. It checks coding style against common practices. On this code, you would get the warning:Bad indentation. Found 2 spaces, expected 4 (bad-indentation)