Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Android

Josh Gold
Josh Gold
12,207 Points
Posted by Josh Gold
Josh Gold
12,207 Points

Open to feedback on my Pirate Spanish app.

My PIrate Spanish app is based on Random Facts app in the training, and then I ran with it.

https://github.com/jogold9/Pirate-Spanish

Aarrrggh.

Josh Gold
Josh Gold
12,207 Points
Josh Gold
Josh Gold
12,207 Points

I still need to fix the buttons so they don't span the entire width of the screen.

Josh Gold
Josh Gold
12,207 Points
Josh Gold
Josh Gold
12,207 Points

Screen captures here: http://imgur.com/a/rsBkL

New feature in the works is a quiz feature, in which you can be promoted from powder monkey to sailor.

1 Answer

Ben Jakuben
STAFF
Ben Jakuben
Treehouse Teacher
Ben Jakuben
Ben Jakuben
Treehouse Teacher

Aaaar, this sure be great app!

The buttons don't expand because of the default padding settings on the RelativeLayout parent of the layout file.

One minor issue is that letters with parts below the line are currently hidden by the buttons. Try adding a bottom margin to your TextView to move it a little bit up from the button. :)

Josh Gold
Josh Gold
12,207 Points
Josh Gold
Josh Gold
12,207 Points

OK I added a 10 dp bottom margin to the TextView. I wasn't seeing that issue; I guess I need to run the program in more screen sizes / resolutions for testing? Because the initial screen does not include the Spanish words showing in the TextView, maybe I was missing that bug. Is there a way I can see the Spanish words in the Preview pain for the XML? Or can I only see the words when via the Genymotion emulator when the program is running?

For the buttons, I am actually not trying to expand them. I am planning to decrease the width of the buttons. As soon as learn more about how layouts work!

Josh