Passing an instance, to an instance. Is this okay?

Question

After completing this code challenge, I have found a two different methods. Just curious as to which is written better.

struct Location {
    let latitude: Double
    let longitude: Double
}

class Business {
    let name: String
    let location: Location

    init(name: String, location: Location) {
        self.name = name
        self.location = location
    }
}

let someBusiness = Business(name: "London", location: Location(latitude: 51.5074, longitude: 0.1278))
'''

Or

struct Location {
    let latitude: Double
    let longitude: Double
}

class Business {
    let name: String
    let location: Location

    init(name: String, location: Location) {
        self.name = name
        self.location = location
    }
}

let londonLocation = Location(latitude: 51.5074, longitude: 0.1278)
let someBusiness = Business(name:" London", location: londonLocation)

Answer 1 · 2017-08-09T07:20:14Z

August 9, 2017 7:20am

It is totally okay both ways you did. Which is better depends on the situation. If somewhere else you would need to use this exact location (for example for creating another instance of a business) then I would do the same following the DRY principle. If you are sure you would never ever use this location again then it is shorter to initialise Location directly as a parameter of Business. But what I'd also say, when you instantiate Location to a different constant, it looks much cleaner. I would prefer to write clean and readable code even if it is 1 line longer.

Hope it helps!

Welcome to the Treehouse Community

Looking to learn something new?

Mitch Little

Mitch Little

Passing an instance, to an instance. Is this okay?

1 Answer

Arman Arutyunov

Arman Arutyunov