Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

CSS

Posted by Sumeet Kumar
Sumeet Kumar
3,519 Points

Please help me improve..

A link to my first website is below, it's not completely finished but I would Ike some input on what I need to improve!

http://www.kumarsxray.com/testing.html

4 Answers

Chris Howell
seal-mask
.a{fill-rule:evenodd;}techdegree seal-36
Chris Howell
Python Web Development Techdegree Graduate 49,702 Points
Chris Howell
.a{fill-rule:evenodd;}techdegree seal-36
Chris Howell
Python Web Development Techdegree Graduate 49,702 Points

Hi Sumeet, So I took a look at your Source Code. I would agree with Viktor, you should definitely shoot for fluid or adaptive design. I took a look at your CSS stylesheets as well.

You already are using a grid system, so you are already on the right track for that. You'll need to learn how to convert all your PT values and pixel values in your CSS to percentages to do this. Also, learn those media queries! :)

Definitely go work on this section and apply what you learn to your site.

Build A Responsive Website

Tata Cheng
Tata Cheng
8,787 Points
Tata Cheng
Tata Cheng
8,787 Points

Hi Sumeet,

Perhaps a san-serif type font for the nav bar and titles could make it look sleeker. Just to differentiate the main headings and navigation from the content text. I'm not sure, but you could test it out and see what that looks like.

Sumeet Kumar
Sumeet Kumar
3,519 Points

I need help with the fonts - I've changed the nav to sans-serif on a local version on my computer. I think it can still use some font changes - any more suggestions?

Viktor Léhner
Viktor Léhner
12,771 Points
Viktor Léhner
Viktor Léhner
12,771 Points

Hi , you are great. Try make a responseve (first fluid or adaptive) design.

Sumeet Kumar
Sumeet Kumar
3,519 Points
Sumeet Kumar
Sumeet Kumar
3,519 Points

Thanks - will get on this!

Chris Howell
seal-mask
.a{fill-rule:evenodd;}techdegree seal-36
Chris Howell
Python Web Development Techdegree Graduate 49,702 Points
Chris Howell
.a{fill-rule:evenodd;}techdegree seal-36
Chris Howell
Python Web Development Techdegree Graduate 49,702 Points

Keep in mind when you create a page that accepts user input. Like your Staff Login page which appears to connect to a database you have set up. If you do not take the proper precautions your code could be left open for SQL injection or Cross-site scripting attacks.

There are courses under the PHP sections that cover how to protect your site from these attacks. Someone could exploit your database to gain access to your users, personal data, or even delete tables or entire databases or completely change your webpage. It just creates a big security hole, so before you put that login form and database out for the public. Make sure it is secure! :)

Also, PHP Academy covers some of these and other security holes with pages.

Sumeet Kumar
Sumeet Kumar
3,519 Points

I have taken off the staff login for now until I can secure it! Thanks!