Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Selecting Multiple Elements

Vladimir Lapcevic
Vladimir Lapcevic
6,363 Points
Posted by Vladimir Lapcevic
Vladimir Lapcevic
6,363 Points

Please provide me the solution.

What is wrong with my line 1 in app.js?

index.html 
<!DOCTYPE html>
<html>
  <head>
    <title>Rainbow!</title>
  </head>
  <body>
    <ul id="rainbow">
      <li>This should be red</li>
      <li>This should be orange</li>
      <li>This should be yellow</li>
      <li>This should be green</li>
      <li>This should be blue</li>
      <li>This should be indigo</li>
      <li>This should be violet</li>
    </ul>
    <script src="js/app.js"></script>
  </body>
</html>
js/app.js 
const listItems = document.querySelector('#rainbow');
const colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];

for(var i = 0; i < colors.length; i ++) {
  listItems[i].style.color = colors[i];    
}
Cooper Runstein
Cooper Runstein
11,850 Points
Cooper Runstein
Cooper Runstein
11,850 Points

Right now you're selecting the list itself, the <ul>, you want to select the children of the list, the <li>, notice that only the ul tag has the class rainbow, which is what the selector is pointing to now.

Edgars M
Edgars M
2,019 Points

Instead of selecting just the <ul> element, you need to select all of its children. You can do that by using querySelectorAll and targeting the <li> elements of #rainbow

1 Answer

Joseph Wasden
Joseph Wasden
20,406 Points
Joseph Wasden
Joseph Wasden
20,406 Points

You need to update your selector to target the li's, not just the parent element. 

const listItems = document.querySelector('#rainbow > li');

Also, querySelector() only selects the first matching selector, so you'll need to use querySelectorAll().

const listItems = document.querySelectorAll('#rainbow > li');

Good luck!

Vladimir Lapcevic
Vladimir Lapcevic
6,363 Points
Vladimir Lapcevic
Vladimir Lapcevic
6,363 Points

Thanks,

I need to refresh my HTML and CSS.