Prime number program issue

Question

I am trying to create a program to take any user input and calculate to see whether it's prime or not and return 0 or 1. 1 would be true and 0 false. I got the main core of the program written and it does work however when I wrap it with while (cin >> n) so that it keeps going as long as there is a prompt to enter a value from the user, it starts getting random and returning inaccurate results. I am writing this in C++ however it's pretty similar concept to C# or any language. Here is my code:

int main() {
    int n; // initialize variable for user input
    bool isPrime = true; // initialize variable for prime state
    cin >> n;

    while (cin >> n) {
        if (n == 1) {
            isPrime = false;
            break;
        }
        for (int i = 2; i <= n/2; i++) {
            if (n % i == 0) {
                isPrime = false;
                break;
            }
        }
        cout << isPrime << "\n";

    }
    return 0;
}

Answer 1 · 2017-02-19T21:12:57Z

February 19, 2017 9:12pm

You need to reset isPrime each time you begin the loop.

Since you initialilze isPrime outside the loop, once you get a False result, all other results will be False. You need to reset it to True as the loop begins again.

Welcome to the Treehouse Community

Looking to learn something new?

andrewgabriel

andrewgabriel

Prime number program issue

Steven Parker

Steven Parker

andrewgabriel

andrewgabriel

1 Answer

Steven Parker

Steven Parker

You need to reset isPrime each time you begin the loop.

Jason Anello

Jason Anello

Steven Parker

Steven Parker