Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

Java Java Objects Creating the MVP Current Progress

Chase Anzalone
Chase Anzalone
3,009 Points

program displays actual string instead of dashes

probably some small error, but i can't find why the program reveals the string to be guessed instead of dashes and current progress.

class Game {

private String answer; private String hits; private String misses;

public Game (String answer) { this.answer = answer; hits = ""; misses = ""; }

public boolean applyGuess(char letter) { boolean isHit = answer.indexOf(letter) != -1; if(isHit) { hits += letter;

}
else
{
  misses += letter;
}
return isHit;

}

public String getCurrentProgress() { String progress = ""; for(char letter : answer.toCharArray()) { char display = '-'; if(hits.indexOf(letter) != -1); { display = letter; } progress += display;

}
     return progress;

}

}

///////////////////////////////////////////////////////////////////////// import java.util.Scanner; class Prompter {

private Game game;

public Prompter(Game game) { this.game = game;

}

public boolean promptForGuess() { Scanner scanner = new Scanner(System.in); System.out.print("Enter a Letter: "); String guessInput = scanner.nextLine(); char guess = guessInput.charAt(0); return game.applyGuess(guess); }

public void displayProgress() { System.out.printf("Try to solve : %s%n",game.getCurrentProgress()); } } /////////////////////////////////////////////////////////////////////////////////////////////////////////////// public class Hangman {

public static void main(String[] args) { Game game = new Game("treehouse"); Prompter prompter = new Prompter(game); prompter.displayProgress(); boolean isHit = prompter.promptForGuess(); if(isHit) { System.out.println("We Got a Hit!"); } else { System.out.println("Oops! missed"); } prompter.displayProgress(); } } //////////////////////////////////////////////////////////////////////////////////////////////////////////////// Picked up JAVA_TOOL_OPTIONS: -Xmx128m
Picked up _JAVA_OPTIONS: -Xmx128m
Picked up JAVA_TOOL_OPTIONS: -Xmx128m
Picked up _JAVA_OPTIONS: -Xmx128m
Try to solve : treehouse
Enter a Letter:

Chase Anzalone
Chase Anzalone
3,009 Points

Sorry about the weird formatting

1 Answer

In Game.java in getCurrentProgress() you have a semicolon that ends your if statement

if(hits.indexOf(letter) != -1); 

therefore the code following display = letter always executes. Remove the semicolon.

Chase Anzalone
Chase Anzalone
3,009 Points

wow i can't believe i didn't notice that lmao thanks man