Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

General Discussion

eeeee eeee
eeeee eeee
16,283 Points

Project for my portfolio

https://github.com/ekeklol/EK_02.git

Hi, can anyone give me honest opinion or this project? What do you think I should change regarding on the design or anything.

Also, can you tell me how should I make the contact form work? Feel free to contribute if you think so :D

Thank you, have a nice day!

It looks like a website - just a bunch of html and css files...?

Why didn't you include a link to the live hosted web site itself?


It might have some nice eye candy, but viewing a folder full of images online in Github is tedious.

If you've got a site that looks nice show it off on Dribble

(if it's going to be part of a portfolio for instance)


Github is mainly for showing off server side code that's impressive --or some kind of app code.


If you think your client side html/css code is impressive then

show it off in a PasteBin, so the "design" can be judged visually.

3 Answers

Kristopher Van Sant
PLUS
Kristopher Van Sant
Courses Plus Student 18,830 Points

Hi Erik! As James mentioned the link you provided is to the websites Github repo so it's a little difficult to judge the design without seeing the actual site.

In regards to the form, you could try and find a php script that you could plug in so that it can send emails. Or you could use a form builder like Wufoo or Simple Form that will handle those scripts for you. You'd still be able to use your form design for certain form builders. OR hopefully someone will contribute and help out that way! :)

Lastly kudos for using Github! Github is great for project management and collaboration. There's a common misconception that Github is just for displaying your code or showing how often you work. It's not, in fact there are many many organizations out there that use Github and have nothing to do with coding or developing. Github is about managing your projects, keeping them organized, collaborating with others and being apart of an awesome community. That being said I really appreciate you encouraging others to contribute to your project! So awesome.

Keep up the awesome work! :)

*Note removed previous critiques since they were for the wrong site. Oops!

Michael Afanasiev
Michael Afanasiev
Courses Plus Student 15,596 Points

Hey Kristopher,

I'm afraid this feedback is for a different Erik :P if you download the .zip file from GitHub, just open the index.html file and you can browser locally the original website.

Kristopher Van Sant
Kristopher Van Sant
Courses Plus Student 18,830 Points

Oh my gosh you are totally right! Haha. Thank you for catching my error! I removed my critiques.

Kristopher Van Sant
Kristopher Van Sant
Courses Plus Student 18,830 Points

Erik Elek I wanted to mention one last thing. When I tried to find your site via google (mistakenly thinking it was already hosted and live) I stumbled across an already built and running site for the same business, with all the exact same information. Did you do that site too? If not are you redesigning their site for them? Or is this just a personal project? If it is a personal project meant just for learning and showing off your skills I'd be careful when you show it on your portfolio. I think you would need to clarify that, if it is a real business, the site you did is not their official site.

Michael Afanasiev
Michael Afanasiev
Courses Plus Student 15,596 Points

I am so sorry Kristopher, I could swear I wrote it with a K but now I noticed it is auto-correcting it! my sincere apologies! :-( (I think it's the 2nd time I do that to you…)

eeeee eeee
eeeee eeee
16,283 Points

Hello Kristopher :) Thank you very much for the reply. The hosted website is also made by me but used a simple bootstrap template long time ago and modified how I could, I don't want that in my portfolio :P So I just made another one from the ground and want to replace.

The business is my fathers and he doesn't mind if I do some changes on the website.

I didn't know that there is no way for you guys to check the design I thought that you could download it and check it locally how Michael said. I'm new to github :P

Thanks very much for your advice regarding the form as well :) and for the encouraging words.

Project for ur portfolio? i have a project that can change ur life. I am building a social networking website, and u guys can join if u want

email me at lakindu1.jayathilaka@gmail.com

Hi Erik, I took another look at your git zipped website.

Even though it's still somewhat tedious to archive it in such a fashion, the site itself doesn't look too bad once you download it, unzip it and run it in a browser.

Had some issues in IE6-IE8, but you should be able to use modernizr to correct that:

https://teamtreehouse.com/library/css-layout-techniques/flexbox-layout/providing-fallbacks-with-modernizr


I like the fluid response grid, but the links back to the main page (from the sub pages) should probably be at the top, not the bottom (so it doesn't have issues on small mobile screens).

The blue to gold(?) to grey gradient just doesn't work for me personally,

but it looks like it's for a business so maybe it's alright in that context.


Noticed something else...

Most responsive menu systems turn into a hamburger icon or a vertically stack set of menu items., so it's interesting you decided to go

with the "shrink the text size of the nav menu items but keep them horizontally oriented" approach.


Kristopher Van Sant mentioned an already built and live site for the same business

(but didn't provide the link)

I believe it is:

http://www.elek-kele.ro/

It is a very nicely responsive liquid/flex grid site, with hamburger icon and a lot more visually striking color images.

The only issue is the text in the header (top dark section) overflows into the green section

instead of pusinh down (and enlarging( the dark header background as the browser viewport

is resized...or you could do a resizing of the text with media query code as in the github site.

The two site could be combined to bring out the best features of both,

which is what my "honest opinion" recommendation would be.


If your site does use php, then there is a way to code with php to

allow the copyright date to reflect the current year:

http://www.signore.net/code/copyright_code.php

eeeee eeee
eeeee eeee
16,283 Points

Hello James,

Thank you very much for the reply and for taking the effort and time to download, unzip and look at/test the website in different browsers even, highly appreciated here.

The already built and live website I made long time ago, it's just a modified bootstrap template I don't think it's something I could show off with in my portfolio since I didn't built it from zero.

I want to change it with something where I know I did everything with my own skills and I want it to be better of course.

I took note of everything you wrote in your post, and I like the idea of having the two sites combined, sounds challenging to me and I'll be working on it asap.

Wish you a great day!