Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python

Daphny Lazarus
Daphny Lazarus
1,590 Points

Python Letter Game Introduction

I followed the video on how to create a letter game and the game will not let me win. I believe that I followed along exactly as video dictated with the exception being my list.

Here is my code

import random

make a list of words

words = [ "little", "minute", "hill", "dislike", "expansion", "bee", "awesome", "check", "obnoxious", "momentous", "pancake", "chilly" ]

while True: start = input("Press enter/return to start, or enter Q to quit") if start.lower() == "q": break # pick a random word secret_word = random.choice(words) bad_guesses = [] good_guesses = []

while len(bad_guesses) < 7 and len(good_guesses) != len(list(secret_word)):

    # draw guessed letters, spaces and strikes
    for letter in secret_word:
        if letter in good_guesses:
            print(letter, end='')
        else:
            print('_', end='')
    print('')
    print("Strikes: {}/7".format(len(bad_guesses)))
    print('')
# take guess
    guess = input("Guess a letter: ").lower()

    if len(guess) != 1:
        print("Cheater! You can only guess a single letter!")
        continue
    elif guess in bad_guesses or guess in good_guesses:
        print("You've already guessed that letter!")
        continue
    elif not guess.isalpha():
        print("You can only guess letters!")
        continue
    if guess in secret_word:
        good_guesses.append(guess)
        if good_guesses == secret_word: 
            print("You win! The word was {}".format(secret_word))
            break
    else:
        bad_guesses.append(guess)
# draw guessed letters and strikes
else:
    print("Your didn't guess it! My secret word was {}".format(secret_word))
#print out win/lose

2 Answers

Seth Kroger
Seth Kroger
56,413 Points

Let's take a closer look at where you handle good guesses:

        if guess in secret_word:
            good_guesses.append(guess)
            if good_guesses == secret_word: 
                print("You win! The word was {}".format(secret_word))
                break

What will happen when 1) you don't guess the letters in the same order as the word, 2) the guessed letter appears more than once in the word?

Daphny Lazarus
Daphny Lazarus
1,590 Points

That is precisely the issue I was trying to describe. If the word has the same letter more than once, there is no way to win the game with the current code. I haven't finished the videos for the sequence but I'd be surprised if that's not brought up. I currently don't know how to work around that issue.

Seth Kroger
Seth Kroger
56,413 Points

In the video, Kenneth compares the length of the guesses and the word, not the guesses and word directly.

if good_guesses == secret_word:
# should be
if len(good_guesses) == len(list(secret_word)):

That takes care of the order issue. You'll probably find the solution to the more than one of a letter issue in the following videos.