Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python

Nathan Freeman
Nathan Freeman
8,145 Points

Python letter_game Could you please review the error in the code?

import random

#make list of words
words = [
    "apple",
    "banana",
    "orange",
    "coconut",
    "strawberry",
    "lime"
]

while True:
    start = input("Press enter/return to start or enter Q to quit")
    if start.lower() == "q":
        break
#pick a random word
secret_word = random.choice(words)
bad_guesses = []
good_guesses = []

while len(bad_guesses) < 7 and len(good_guesses) != len(list(secret_word)):
    for letter in secret_word:
        print(letter, end=" ")
    else:
        print("_", end=" ")

    print(" ")
    print("Strikes: {}/7".format(len(bad_guesses)))

    guess = input("Guess a letter: ").lower()

    if len(guess) != 1:
        print("You can only guess a single letter!")
        continue
    elif guess in bad_guesses or guess in secret_word:
        print("You've already guessed that letter!")
        continue
    elif not guess.isalpha():
        print("You can only guess letters!")
        continue

    if guess in secret_word:
        good_guesses.append(guess)
        if len(good_guesses) == len(list(secret_word)):
            print("You win! The word was {}".format(secret.word))
            break
        else:
            bad_guesses.append(guess)
else:
    print("You didn't guess it! My secret word was {}".format(secret_word))

1 Answer

Chris Freeman
MOD
Chris Freeman
Treehouse Moderator 68,441 Points

Found a few errors in the code. See embedded comments below:

import random

# make list of words
words = [
    "apple",
    "banana",
    "orange",
    "coconut",
    "strawberry",
    "lime"
]

# FIXED removed 'while True:'
# why? This loop would run until q entered, then run remaining code anyway
start = input("Press enter/return to start or enter Q to quit")
if start.lower() == "q":
    # FIXED replace 'break' with 'exit'
    # why?  'break' only leaves this 'while' not the program
    exit()

# pick a random word
secret_word = random.choice(words)
bad_guesses = []
good_guesses = []

# FIXED changed from 'len(good_guesses) != len(list(secret_word)):'
# why? to cover case when secret_word has repeated letters
while len(bad_guesses) < 7 and len(good_guesses) != len(set(secret_word)):
    for letter in secret_word:
        # FIXED check if this secret_word letter is in good_guesses
        # why? original loop printed every letter, then the else added '_'
        if letter in good_guesses:
            print(letter, end=" ")
        # else indented to print if letter not in good_guesses
        else:
            print("_", end=" ")

    print(" ")
    print("Strikes: {}/7".format(len(bad_guesses)))

    guess = input("Guess a letter: ").lower()

    if len(guess) != 1:
        print("You can only guess a single letter!")
        continue
    # FIXED changed from 'or guess in secret_word':
    # why? letters secret_word may not have been guessed already
    elif guess in bad_guesses or guess in good_guesses:
        print("You've already guessed that letter!")
        continue
    elif not guess.isalpha():
        print("You can only guess letters!")
        continue

    if guess in secret_word:
        good_guesses.append(guess)
        # FIXED changed from 'len(good_guesses) == len(list(secret_word)):'
        # why? to cover case when secret_word has repeated letters
        if len(good_guesses) == len(set(secret_word)):
            # FIXED typo 'secret.word'
            print("You win! The word was {}".format(secret_word))
            break
    # FIXED unindent else for 'bad_guesses'
    # why? letter was added to bad_guesses if not "Won"
    else:
        bad_guesses.append(guess)
else:
    print("You didn't guess it! My secret word was {}".format(secret_word))