Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Django ORM Total Control Q

Dmitry Karamin
Dmitry Karamin
10,099 Points
Posted by Dmitry Karamin
Dmitry Karamin
10,099 Points

Q objects

the task is to update the product_detail view so that it only shows Reviews for the selected product if the Review has a rating of 8 or more or was created in the last 4 weeks? Oh, and don't change the ordering, we still want newest first.

To my mind everything is fine. So whats wrong?

Bummer tells, that doesn't find right queryset!

products/views.py 
import datetime

from django.db.models import Q
from django.shortcuts import render, get_object_or_404

from . import models


def good_reviews(request):
    reviews = models.Review.objects.filter(rating__gte=3)
    return render(request, 'products/reviews.html', {'reviews': reviews})


def recent_reviews(request):
    six_months_ago = datetime.datetime.today() - datetime.timedelta(days=180)
    reviews = models.Review.objects.exclude(created_at__lt=six_months_ago)
    return render(request, 'products/reviews.html', {'reviews': reviews})


def product_detail(request, pk):
    product = get_object_or_404(models.Product, pk=pk)
    four_weeks_ago = datetime.datetime.today() - datetime.timedelta(weeks=4)
    reviews = product.review_set.order_by('-created_at').filter(
                                                            Q(rating__gte=8)|Q(created_at__lte=four_weeks_ago)
                                                            )
    return render(request, 'products/product_detail.html', {'product': product, 'reviews': reviews})

2 Answers

Chris Freeman
MOD
Chris Freeman
Treehouse Moderator 68,454 Points
Chris Freeman
Chris Freeman
Treehouse Moderator 68,454 Points

You are very close. Comparing datetimes can seem backwards. The challenge is looking for review in the last 4 weeks. When comparing to four_weeks_ago, you want datetime objects that are newer, which means they have a more recent time value. datetime object value increases as they get newer (and time moves forward). So you want dates greater than or equal to four_weeks_ago this means using Q(created_at__gte=four_weeks_ago)

Dmitry Karamin
Dmitry Karamin
10,099 Points
Dmitry Karamin
Dmitry Karamin
10,099 Points

it's very sad that i can't check output of the code interactively. a lot of such stupid question would be gone.

Thank you