Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community!

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Selecting Multiple Elements

Bibiana Balbuena Barbosa
Bibiana Balbuena Barbosa
14,768 Points
Posted by Bibiana Balbuena Barbosa
Bibiana Balbuena Barbosa
14,768 Points

Query Selector challenge, can't do it

as my understanding either of the following syntax should work: var listItems = getElementById('rainbow') or var listItems = querySelectorAll('#rainbow')

What am I doing wrong?

js/app.js 
var listItems = document.querySelectorAll('#rainbow');
var colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];

for(var i = 0; i < colors.length; i ++) {
  listItems.[i].style.color = colors[i];    
}
index.html 
<!DOCTYPE html>
<html>
  <head>
    <title>Rainbow!</title>
  </head>
  <body>
    <ul id="rainbow">
      <li>This should be red</li>
      <li>This should be orange</li>
      <li>This should be yellow</li>
      <li>This should be green</li>
      <li>This should be blue</li>
      <li>This should be indigo</li>
      <li>This should be violet</li>
    </ul>
    <script src="js/app.js"></script>
  </body>
</html>
Cheo R
Cheo R
37,150 Points
Cheo R
Cheo R
37,150 Points 
listItems.[i]

Notice anything about the code above?

5 Answers

Piotr Manczak
.a{fill-rule:evenodd;}techdegree seal-36
Piotr Manczak
Front End Web Development Techdegree Graduate 25,171 Points

You are grabbing <ul> instead of <li>. You need an array of html elements(<li>), not a list of #rainbow. Having said that I had similar problem with this particular challenge as the instruction is a bit unclear.

Piotr Manczak
seal-mask
.a{fill-rule:evenodd;}techdegree seal-36
Piotr Manczak
Front End Web Development Techdegree Graduate 25,171 Points
Piotr Manczak
.a{fill-rule:evenodd;}techdegree seal-36
Piotr Manczak
Front End Web Development Techdegree Graduate 25,171 Points

var listItems = document.querySelectorAll('#rainbow li');

Bibiana Balbuena Barbosa
Bibiana Balbuena Barbosa
14,768 Points
Bibiana Balbuena Barbosa
Bibiana Balbuena Barbosa
14,768 Points

I've remove the dote, still doesn't work. But thanks for the hint.

Piotr Manczak
.a{fill-rule:evenodd;}techdegree seal-36
Piotr Manczak
Front End Web Development Techdegree Graduate 25,171 Points

Cheo wanted to draw your attention to the fact that you need to grab a collection of html items, which is an array instead of just one item.

Piotr Manczak
seal-mask
.a{fill-rule:evenodd;}techdegree seal-36
Piotr Manczak
Front End Web Development Techdegree Graduate 25,171 Points
Piotr Manczak
.a{fill-rule:evenodd;}techdegree seal-36
Piotr Manczak
Front End Web Development Techdegree Graduate 25,171 Points

listItems[i] instead of listItems.[i]