Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Practice Selecting Elements

Dalton Wolfe
PLUS
Dalton Wolfe
Courses Plus Student 2,430 Points
Posted by Dalton Wolfe
Dalton Wolfe
Courses Plus Student 2,430 Points

queryselectorall

I can't seem to get querySelectorAll to work here. I have also tried getElementsByTagName/Class/Id. Not sure what I'm missing.

js/app.js 
let navigationLinks = document.querySelectorAll('.nav');
let galleryLinks;
let footerImages;
index.html 
<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8">
    <title>Nick Pettit | Designer</title>
    <link rel="stylesheet" href="css/normalize.css">
    <link href='http://fonts.googleapis.com/css?family=Changa+One|Open+Sans:400italic,700italic,400,700,800' rel='stylesheet' type='text/css'>
    <link rel="stylesheet" href="css/main.css">
    <link rel="stylesheet" href="css/responsive.css">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
  </head>
  <body>
    <header>
      <a href="index.html" id="logo">
        <h1>Nick Pettit</h1>
        <h2>Designer</h2>
      </a>
      <nav>
        <ul>
          <li><a href="index.html" class="selected">Portfolio</a></li>
          <li><a href="about.html">About</a></li>
          <li><a href="contact.html">Contact</a></li>
        </ul>
      </nav>
    </header>
    <div id="wrapper">
      <section>
        <ul id="gallery">
          <li>
            <a href="img/numbers-01.jpg">
              <img src="img/numbers-01.jpg" alt="">
              <p>Experimentation with color and texture.</p>
            </a>
          </li>
          <li>
            <a href="img/numbers-02.jpg">
              <img src="img/numbers-02.jpg" alt="">
              <p>Playing with blending modes in Photoshop.</p>
            </a>
          </li>
        </ul>
      </section>
      <footer>
        <a href="http://twitter.com/nickrp"><img src="img/twitter-wrap.png" alt="Twitter Logo" class="social-icon"></a>
        <a href="http://facebook.com/nickpettit"><img src="img/facebook-wrap.png" alt="Facebook Logo" class="social-icon"></a>
        <p>&copy; 2016 Nick Pettit.</p>
      </footer>
    </div>
  <script src="js/app.js"></script>
  </body>
</html>

4 Answers

Steven Parker
Steven Parker
231,269 Points
Steven Parker
Steven Parker
231,269 Points

Using querySelectorAll is a good idea, but you need a different selector. You want to target the links (a) inside the nav element, so a descendant selector (where the container and target are separated by a space) might be useful here.

Also, "nav" is a tag name and not a class name, so it should not be prefixed with a period.

Mustafa Khan
Mustafa Khan
6,224 Points
Mustafa Khan
Mustafa Khan
6,224 Points

you don't need .nav, you want to target the nav, tags and anything nested in it, not the nav class

maikelvreugdenhil
maikelvreugdenhil
1,762 Points
maikelvreugdenhil
maikelvreugdenhil
1,762 Points

You're trying to access a class.

nav is a valid HTML5 tag. You need to use the correct selector syntax in your code in order to access the correct element in the DOM.

id = #demo class = .demo tag = demo