Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Numbers The Math Object Random Number Challenge – Two Numbers Solution

Greg Taylor
Greg Taylor
798 Points
Posted by Greg Taylor
Greg Taylor
798 Points

Random Number Challenge - two numbers solutions

I tried it this way and it also worked, what do you think? Won't it cause some errors based on different user inputs.

https://w.trhou.se/1umcfw3jb4

1 Answer

Steven Parker
Steven Parker
229,771 Points
Steven Parker
Steven Parker
229,771 Points

One issue is with the testing of the numbers as if they were Boolean (if (wholeNumber && wholeNumber2)). If either number input is 0, this will be interpreted as false just as a NaN would be. To avoid this, you can check the numbers using isNaN: if (!isNaN(wholeNumber) && !isNaN(wholeNumber2)).

Also Math.random does not take an argument, and the formula used is not correct for selecting a number inclusively between two limits. The correct formula would be: Math.floor(Math.random() * (wholeNumber - wholeNumber2 + 1) + wholeNumber2).