Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

Android Google Play Services Interacting with Your API Display Loading and Error States

Kourosh Raeen
Kourosh Raeen
23,732 Points
Posted by Kourosh Raeen
Kourosh Raeen
23,732 Points

Redundant call to showList() method in MainActivity.java

In the onCreate() method of MainActivity.java we have the following code:

if (savedInstanceState == null) {
    showLoading();
    Etsy.getActiveListings(adapter);
} else {
    if (savedInstanceState.containsKey(STATE_ACTIVE_LISTINGS)) {
        adapter.success((ActiveListings) savedInstanceState.getParcelable(STATE_ACTIVE_LISTINGS), null);
        showList(); 
    } else {
        showLoading();
        Etsy.getActiveListings(adapter);
    }
}

The call to showList() above seems to be redundant since inside the success() method of the adapter we have this code: this.activity.showList().

Kourosh Raeen
Kourosh Raeen
23,732 Points
Kourosh Raeen
Kourosh Raeen
23,732 Points

Actually, Jamie Huson removes this method call later in the "Integrating GoogleServicesHelper" section.