Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Android Google Play Services Interacting with Your API Display Loading and Error States

Kourosh Raeen
Kourosh Raeen
23,733 Points

Redundant call to showList() method in MainActivity.java

In the onCreate() method of MainActivity.java we have the following code:

if (savedInstanceState == null) {
    showLoading();
    Etsy.getActiveListings(adapter);
} else {
    if (savedInstanceState.containsKey(STATE_ACTIVE_LISTINGS)) {
        adapter.success((ActiveListings) savedInstanceState.getParcelable(STATE_ACTIVE_LISTINGS), null);
        showList(); 
    } else {
        showLoading();
        Etsy.getActiveListings(adapter);
    }
}

The call to showList() above seems to be redundant since inside the success() method of the adapter we have this code: this.activity.showList().

Kourosh Raeen
Kourosh Raeen
23,733 Points

Actually, Jamie Huson removes this method call later in the "Integrating GoogleServicesHelper" section.