re-setting the todo.edited back boolean "false" after save?

Question

so i've been trying to add a feature to the todos project i feel it needs, but have been unsuccessful in making it happen. i thought i'd ask here for help?

it struck me that each time you save, it keep incrementing and saving the entire history of todos that have ever been edited, even if you haven't made any changes to the previous todos you edited in this later round of saving. so consequently, the feedback you get in the console.log() is 3 todos have been saved, the first time, then, if you edit and save two more todos, you get 5 todos have been saved. it struck me it should reset each time and just save & notify on the latest todos saved, as in the second time you should see 2 todos have been saved.

however, i can't get it to work.

i tried putting a for... in loop in either services/data.js this.saveTodos or in controllers/main.js $scope.saveTodos that, after most of the other logic, re-set the todos that had todo.edited now set to boolean true back to boolean false. but each time i try, i'd get an error in the console from angular.js saying i can't alter it as it is a readonly object.

is there some other ng-directive i should use? if so, which one? some way to make the object read-write, and then switch it back to read-only after writing to it? please let me know.

best,

— faddah

 portland, oregon, u.s.a.

Answer 1 · 2016-03-26T17:31:49Z

March 26, 2016 5:31pm

I would recommend adding just one line of code (todo.edited = false) in the filter callback function:

$scope.saveTodos = function() {
    var filteredTodos = $scope.todos.filter(function(todo) {
    if(todo.edited) {
        todo.edited = false;
        return todo;
    }
    });
    console.log(filteredTodos);
    dataService.saveTodos(filteredTodos);
};

How does this work for everyone?

Answer 2 · 2016-02-18T01:31:16Z

February 18, 2016 1:31am

Hi, I felt the same way that after you click save button, the "EDITED" should be gone. So I simply changed the $scope.saveTodos in main.js to the below, and it works fine.

$scope.saveTodos = function() {
        var savedTodos = $scope.todos.map(function(todo) {
            if(todo.edited) {
                todo.edited = false;
                return todo;
            }
        });

        dataService.saveTodos(savedTodos);

    };

However, in this way, if you follow the teacher to log the savedTodos.length, it's gonna be 6 all the time because it iterates the whole array.

Answer 3 · 2016-04-15T02:21:23Z

April 15, 2016 2:21am

I actually reset the 'edited' property in my service instead of my controller.

like so:

this.saveTodos = function (todos) {
        // if my array isn't empty, confirm save.
        if (todos.length > 0) {
            for (var i = 0; i < todos.length; i++) {
                console.log(todos[i].name + " has been saved! ");
                todos[i].edited = false;
            }
        } else {
            console.log("There are no changes to save.");
        }
    };

Welcome to the Treehouse Community

Looking to learn something new?

Faddah Wolf

Faddah Wolf

re-setting the todo.edited back boolean "false" after save?

akak

akak

3 Answers

Andrew Sams

Andrew Sams

Hello World

Hello World

Patrick O'Dacre

Patrick O'Dacre