Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Android Android Lists and Adapters (2015) Lists with RecyclerViews Creating a RecyclerView ViewHolder

Diego Marrs
Diego Marrs
8,243 Points
Posted by Diego Marrs
Diego Marrs
8,243 Points

Return type?

Hello

I'm stuck on this challenge, i'm doing what it tells me to do but I get an error anyway:

./GameAdapter.java:29: error: invalid method declaration; return type required
      public HourViewHolder(View itemView) {
             ^
1 error

Code:

GameAdapter.java 
public class GameAdapter extends RecyclerView.Adapter<GameAdapter.GameViewHolder> {

    private Game[] mGames;

    public GameAdapter(Game[] games) {
        mGames = games;
    }

    @Override
    public GameViewHolder onCreateViewHolder(ViewGroup parent, int viewType) {
        return null;
    }

    @Override
    public void onBindViewHolder(GameViewHolder holder, int position) {
        // code omitted for brevity
    }

    @Override
    public int getItemCount() {
        return 0;
    }

    /* Add your code here */

    public class GameViewHolder extends RecyclerView.ViewHolder {
      public TextView mTitleLabel;

      public HourViewHolder(View itemView) {
        super(itemView);
        mTitleLabel = (TextView) itemView.findViewById(R.id.titleLabel);
      }
    }
}

Please help!

1 Answer

Benjamin Barslev Nielsen
Benjamin Barslev Nielsen
18,958 Points
Benjamin Barslev Nielsen
Benjamin Barslev Nielsen
18,958 Points

The problem is what is supposed to be your constructor in the innerclass GameViewHolder:

 public HourViewHolder(View itemView) {
    super(itemView);
    mTitleLabel = (TextView) itemView.findViewById(R.id.titleLabel);
}

A constructor should have the same name as the class, it is a constructor for, in this case GameViewHolder. Therefore the solution would be:

 public GameViewHolder(View itemView) {
    super(itemView);
    mTitleLabel = (TextView) itemView.findViewById(R.id.titleLabel);
}

When you do not use the correct name, the Java compiler assumes it is a ordinary method and if it was a ordinary method, a return type was needed.

Diego Marrs
Diego Marrs
8,243 Points
Diego Marrs
Diego Marrs
8,243 Points

Aw man! I meant to put in GameViewHolder! X(

Thanks though!