Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

CSS

Posted by Srdjan Cestic
Srdjan Cestic
6,855 Points

Review of my portfolio page code

At this moment I'm finishing my portfolio page like Nick Pettit made.

I do it yesterday evening and today evening myself, and I just go back few times to Treehouse to see where is problem when I don't know what to do next.

I made some changes in code. Of course I can't code identical code from A to Z, but I think my code is ok, and I would definetly like to hear what others think.

Here is my workspace: https://w.trhou.se/3fcemz5ijf

3 Answers

Jacob Mishkin
Jacob Mishkin
23,118 Points

I previewed the page it looks fine, but two things should be done, one change the color of the font just above the img's. Its gray and not readable. Second create some space or footer at the bottom. After that, It looks fine.

When designing, always think Usability.

Srdjan Cestic
Srdjan Cestic
6,855 Points

Thanks you Jacob, I'll do it.

Jacob Mishkin
Jacob Mishkin
23,118 Points

Not a problem, remember until you are working for a designer, you are the designer. If you feel that something works go for it.

Srdjan Cestic
Srdjan Cestic
6,855 Points
Srdjan Cestic
Srdjan Cestic
6,855 Points

Hi Jacob, can you tell me is this code good? Here's link: https://w.trhou.se/qygfzjlge8

Jacob Mishkin
Jacob Mishkin
23,118 Points

Your code looks fine. Do you have anything in particular you were curious about.

Jacob Mishkin
Jacob Mishkin
23,118 Points

Your code looks fine. Do you have anything in particular you were curious about.

Srdjan Cestic
Srdjan Cestic
6,855 Points
Srdjan Cestic
Srdjan Cestic
6,855 Points

I curios about units I need to use because I need to start first with mobile friendly website, and then will be a much easier to develop website to look good on larger screens, Nick really great explain that and I'll go that way.

This website isn't built in that way beacuse I practice and a little experiment with praticular syntax I learn.

But margin and padding values really annoying, once time is px and once time is %. Is there any rule I follow and solve this problem with units. I know that is % best way to build responsive website, but instructors always put some px and that confuse me.