Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

HTML

Review on HTML

Hi,

WOuld you say this code is good? just HTML. What about aside with column in it? namings u know.

1 Answer

I'd probably take out the section tag since there aren't "sections" on the page. And replace the div around the services navigation with a nav tag and the main content with main.

http://codepen.io/timknight/pen/VvxKvb?editors=100

Well, nice to see some adjustments , can see now better ways :D Oh , if treehouse would do a re-view on sites you build like 5 pages for example ud pay 10 pounds for the review and they show you every single thing you could improve or something .

Thank you!

One question again, i have a class, for example bg-white, where would you put that class? i want each collumn to have a different background , so i just want to put bg-white in all fo them , but so thers a space between collumn, so would i put that in the col-md-6 or make a new div and put bg-white or ? i just really want to make and start to write very clean HTML .

I put it into the collumns like this , im about the class white-bg in the collumn that will make the column white.

I think your bg-white placement is okay, but it's not really necessary. By default your page's background is going to be white, so just create classes that change the default behavior... like those for your other colors.

Well, what im doing is that the bg is grey and im adding to it white bg and padding with my class padding-content.

But if thats the right way to do it.

I just really want to write good HTML : p becaust then my CSS will get better and you know, acomplish the Objective. HTML and CSS, then move into WP anc acomplish that aobjective about making it perfect. Etc.. so i actually learn not thorw random html etc.. not caring

Konrad,

I think you're at a great start here... learning HTML and CSS in general is always going to be filled with constant adjustments in your process. There rarely is a right and wrong way as much as there is a preferred way which you'll get even more of a handle on with experience. If your background is grey, then having a bg-white class works great.

What about OOCSS ? Where you use these e.g styles or naming for buttons and we could assume the namings are perfect?

Konrad,

I'm not sure what you're asking in terms of OOCSS. Object-Oriented CSS is a CSS naming and structural methodology for CSS mostly created with the purpose of maintaining large projects. The important thing at this point though wouldn't necessary be to get weighed down by various current methodologies so much as just follow what feels right for you. If you start working with a team on a project that would be something to discuss with the team to see what type of naming conventions the group likes. But I won't say that of BEM or OOCSS or whatever, that one is necessarily better... it's just a personal choice.

I get it better now. Thank you!

You're welcome Konrad.