Re-write the code to use a do...while loop. What's wrong with my code?

Question

why this gives me an error?

script.js

var secret;
do{
 secret += prompt("What is the secret password?");
}
while (secret !== "sesame") {
document.write("You know the secret password. Welcome.");
}

index.html

<!DOCTYPE html>
<html>
<head>
  <meta charset="utf-8">
  <title>JavaScript Loops</title>
</head>
<body>
<script src="script.js"></script>
</body>
</html>

Answer 1 · 2019-02-09T01:27:14Z

February 9, 2019 1:27am

Hi Yara,

You're getting an error for two reasons, both of which are small and easy to fix.

First, your line:

secret += prompt("What is the secret password?");

+= is the same thing as

secret = secret + prompt("What is the secret password?");

So it concatenates the new password to the old password and checks that. If the computer tries 100 times, you will have a gigantic password string of 100 passwords strung together, which is never going to match. Instead, just use a regular = sign, like you see on the first line of the original challenge.

// Do this:
secret = prompt("What is the secret password?");

Second, your while condition is good, but it doesn't take { } afterwards. The do-while template looks like this:

do{
  // Stuff
}
while ([this condition is true])
// No curly braces after... the do-while is done now and
// the code just continues per normal after this.

So you just need to take out the set of curly braces after while (), and have the document.write statement by itself on a line (not inside curly braces).

Those two things should make it work! Good luck! :-)

Welcome to the Treehouse Community

Looking to learn something new?

Yarstan Jae

Yarstan Jae

Re-write the code to use a do...while loop. What's wrong with my code?

1 Answer

Louise St. Germain

Louise St. Germain