Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Traversing the DOM Solution: Using nextElementSibling

Tomas Rinblad
seal-mask
.a{fill-rule:evenodd;}techdegree
Tomas Rinblad
Full Stack JavaScript Techdegree Student 12,427 Points
Posted by Tomas Rinblad
.a{fill-rule:evenodd;}techdegree
Tomas Rinblad
Full Stack JavaScript Techdegree Student 12,427 Points

Same code as video, not responding on click

Hello.

I have done the exact same as in the code in the video, but when i click on down button it does not work anyway. Up and Remove works but down refuses to respond.

can u please check and see?

listUl.addEventListener("click", (event) => { if(event.target.tagName == "BUTTON"){

if(event.target.className == "remove"){
  let li = event.target.parentNode;
  let ul = li.parentNode;
  ul.removeChild(li);
  }

if(event.target.className == "up"){
  let li = event.target.parentNode;
  let prevLi = li.previousElementSibling;
  let ul = li.parentNode;
  if(prevLi){
  ul.insertBefore(li,prevLi);
    }

  if(event.target.className == "down"){
    let li = event.target.parentNode;
    let nextLi = li.nextElementSibling;
    let ul = li.parentNode;
    if(letLi){
    ul.insertBefore(nextLi, li);
      }
  }
}

} } );

4 Answers

Andreas Nyström
Andreas Nyström
8,887 Points
Andreas Nyström
Andreas Nyström
8,887 Points

You are missing a end bracket on the second if-statement. You're closing 

  if(prevLi){
  ul.insertBefore(li,prevLi);
    }

But not the big if-statement. I'm guessing the other statement isnt suppose to go into the second if? If it is it should be an else if. Hope this helps.

So this: 

if(event.target.className == "remove"){
  let li = event.target.parentNode;
  let ul = li.parentNode;
  ul.removeChild(li);
  }

if(event.target.className == "up"){
  let li = event.target.parentNode;
  let prevLi = li.previousElementSibling;
  let ul = li.parentNode;
  if(prevLi){
  ul.insertBefore(li,prevLi);
    }

  if(event.target.className == "down"){
    let li = event.target.parentNode;
    let nextLi = li.nextElementSibling;
    let ul = li.parentNode;
    if(letLi){
    ul.insertBefore(nextLi, li);
      }
  }
}

Should probably be: 

if(event.target.className == "remove"){
  let li = event.target.parentNode;
  let ul = li.parentNode;
  ul.removeChild(li);
  }

if(event.target.className == "up"){
  let li = event.target.parentNode;
  let prevLi = li.previousElementSibling;
  let ul = li.parentNode;
  if(prevLi){
  ul.insertBefore(li,prevLi);
    }
}
if(event.target.className == "down"){
  let li = event.target.parentNode;
  let nextLi = li.nextElementSibling;
  let ul = li.parentNode;
  if(letLi){
  ul.insertBefore(nextLi, li);
    }
}
Steve Gallant
Steve Gallant
14,943 Points
Steve Gallant
Steve Gallant
14,943 Points

Also, in your final if statement, you are testing for 'letLi', where I think you want to test for 'nextLi'?

Rune Larsen
Rune Larsen
25,877 Points
Rune Larsen
Rune Larsen
25,877 Points

I did the same thing. Sometimes when you copy (or borrow) code, even within the same project, it is important to get all the code you want. In this case it was just a } that was missing, and all the code stopped working.

Andrew Comiskey
PLUS
Andrew Comiskey
Courses Plus Student 3,338 Points
Andrew Comiskey
Andrew Comiskey
Courses Plus Student 3,338 Points

Now I can appreciate why we should format nested braces properly. Each for, if, etc statement should have a brace directly below it to ensure you don't miss any.