Same Code Worked - Stopped Working

Question

Hi, I'm working on a project that updates contents on the web page using timers. This has been breaking on Chrome updates (it works on a Samsung Galaxy 5 but not Galaxy 6, iPhone 5 but not iPhone 6).

So I have two delay timers (I'm sure there's cleaner ways but I'm new and this is what has worked for me on this project) and when these delay timers trigger something changes (for the sake of this example it's console.log). But some recent update has broken these delay timers from triggering. I tried console.log prepareDelay1 and delay variables but it comes up undefined (and not the numbers it's supposed to be) I think it might have to do with scope or where I'm calling it.

Another note: I put the console.log(prepareDelay1) in the timerProgram and this logs the time (for example prepareDelay1 logs 6) but this doesn't trigger the function prepareDelay1.

Here is the simplified code:

var cycle = 0;
//This bit of code works fine, it's my timer
function getTimeRemaining(endtime){
    var time = timer;
    var seconds = Math.floor( (timer/1000) % 60 );
    var minutes = Math.floor( (timer / 1000 / 60 ) % 60 );
    return {
        'total': timer,
        'minutes': minutes,
        'seconds': seconds
    };


//Where Problem starts...       

function timerProgram(){
    if ( cycle !== 0 && timer >=0){
        console.log ('Working');
        var time = timer;
        var time = getTimeRemaining(timer); 
        $('#timer').text(time.minutes + ":" + time.seconds );
        timer -= 1000;
    }else{
        console.log('Something has broken'); //this runs after the timer goes past 0 after the initial timer (5 seconds) is finished
    }
};

//There is a link that when pressed updates the cycle to cycle 1

if( cycle == 1 ){
    cycle = 1;
    updateUser("cycle",cycle); //This is local storage which saves the state as the program updates
    var clock = setInterval(timerProgram, 999);
    var delayTime = setTimeout(delay,9000);
    var prepareDelay = setTimeout(prepareDelay1,6000);
    timer = 5000; //This works
    console.log(prepareDelay1);
    console.log(delay);

    function prepareDelay1(){
        console.log('Hi');
        timer = 1999; //This doesn't happen instead I get the console message 'Something has broken'
    };
        function delay(){
            if (cycle === 1){
                clock = clearInterval(clock);
                cycle = 2;
                updateUser("cycle",cycle);
                timer = 0;
                timer = 12000; //Does not run becauuse prepareDelay1 never triggers either
                clock = setInterval(timerProgram, 999);
                console.log("Hi, now changed to cycle 2");
                cycle = 3;
                updateUser("cycle",cycle);
            }else{
                console.log('Something is wrong');
            }
        };

Answer 1 · 2016-04-04T20:21:16Z

April 4, 2016 8:21pm

I don't see you calling the prepareDelay1 function anywhere, but you are trying to log it as a variable. Could that be the error?

Answer 2 · 2016-04-07T21:38:05Z

April 7, 2016 9:38pm

I tried this, but what ends up happening is it runs instantly without the delay...it's definitely related to when it's being called. I had to also define the variables as such:

var delay; var prepareDelay1;

So now it's not undefined but the delays won't actually trigger. This still won't actually run though. If anyone is genuinely interested in the code feel free to message me and I'll share the full code on Github. If anyone has any other suggestions please pass them along.

Answer 3 · 2016-04-08T15:29:42Z

April 8, 2016 3:29pm

function prepareDelay1(){
    console.log( 'Hi' );
    timer = 1999;

function delay(){
    if (cycle === 1){
        clock = clearInterval( clock );
        cycle = 2;
        updateUser( "cycle", cycle );
        timer = 0;
        timer = 12000;
        clock = setInterval(timerProgram, 999);
        console.log( "Hi, now changed to cycle 2" );
        cycle = 3;
        updateUser ("cycle", cycle );
    }else{
        console.log( 'Something is wrong' );
    } // end if else
}


if ( cycle == 1 ){
    cycle = 1;
    updateUser( "cycle", cycle );
    var clock = setInterval( timerProgram, 999 );

    // Wrapping the function calls in anonymous functions. 
    // This is also good if you want to pass arguments to your functions.
    var delayTime = setTimeout( function() { delay(); }, 9000 );
    var prepareDelay = setTimeout(function() { prepareDelay1(); }, 6000);

    timer = 5000;
    console.log(prepareDelay1);
    console.log(delay); // Where is this var "living"?
} // end if

Welcome to the Treehouse Community

Looking to learn something new?

Rich P

Rich P

Same Code Worked - Stopped Working

3 Answers

Henrik Hansen

Henrik Hansen

Rich P

Rich P

Henrik Hansen

Henrik Hansen

Rich P

Rich P

Rich P

Rich P

Henrik Hansen

Henrik Hansen