Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Object-Oriented JavaScript Getters and Setters Creating Setter Methods

Posted by Daniel Bateman
Daniel Bateman
13,268 Points

Setters Code Challenge Difficulty

Followed the same format that she mentioned in the video- having trouble figuring out what I'm doing wrong.

Would anyone mind helping me critique my code? Thanks in advance!

creating_setters.js 
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }
  get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }

  set major(major){
    if (this.level === 'Senior' || this.level === 'Junior'){
      this.major = 'major';
    } else {
       this.major = 'None';
}


}

    }
}

var student = new Student(3.9, 60);

2 Answers

Qiuhua Pan
Qiuhua Pan
5,776 Points
Qiuhua Pan
Qiuhua Pan
5,776 Points

I am fairly new to Javascript, but could the answer be that there is a mistake with the quotations? (i.e. in the "set major (major)", both Senior and Junior are preceded with ' and followed by ")

Daniel Bateman
Daniel Bateman
13,268 Points

I did notice that, fixed it but still returned "Unexpected Identifier"

 set major(major) {
  if (this.level === 'Senior' || this.level === 'Junior') {
    this.major = major;
  } else {
    this.major = 'none';
  }

Above is what I have now.

Ashley Boucher
STAFF
Ashley Boucher
Treehouse Teacher
Ashley Boucher
Ashley Boucher
Treehouse Teacher

Hey Daniel,

You're really close! Try using a backing property instead of referencing the major property directly inside your if statement.

Good luck!