Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

Python Customizing Django Templates Building Custom Filters Custom Tags

Jonatan Witoszek
Jonatan Witoszek
15,384 Points

Shouldn't we escape the markdown_text before we mark it as safe?

Shouldn't we escape the markdown_text from any HTML tags before we plug it into the markdown2.markdown function? Considering that only selected users have access to Django Admin, should we be worried about escaping and a possibility of XSS?

Anyway... If someone is as paranoid as I am, I've dug into documentation and found a way to escape any HTML characters before we turn markdown into safe HTML that is meant to display on the website:

from django.utils.html import escape
@register.filter('markdown_to_html')
def markdown_to_html(markdown_text):
    """Converts markdown text to HTML"""
    html_body = markdown2.markdown(escape(markdown_text))
    return mark_safe(html_body)