Solved the whileLoops bonus question in a different way. Is this still considered good code?

Question

I solved the challenged using the code below. It doesn't have the declaration of the i variable before the while loop and it waits to modify the text string until after running the Math methods so the number 8 prints to the console.

It works but I'd like to make sure it's considered good code.

My solution:

while (i !==8) { i = Math.floor(Math.random() * 10); text += i + " "; }

Instructors solution:

i = Math.floor(Math.random() * 10);

while (i !==8) { text += i + " "; i = Math.floor(Math.random() * 10); } text += i;

Thanks in advance!

Answer 1 · 2019-06-14T23:12:24Z

June 14, 2019 11:12pm

Well, you'll wind up with an extra space at the end of "text". But more importantly, when you first enter the loop you'll be testing "i" before any value has been assigned. You may get away with it, but "good practice" is to never assume what a variable might contain unless your code put something into it.

The "do/while" loop form would be better suited to your modifications, since it allows the body code to run before the first test is done.

Welcome to the Treehouse Community

Looking to learn something new?

Stacey Auguste

Stacey Auguste

Solved the whileLoops bonus question in a different way. Is this still considered good code?

1 Answer

Steven Parker

Steven Parker