Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript jQuery Basics (2014) Creating a Password Confirmation Form Perfect

Will Macleod
PLUS
Will Macleod
Courses Plus Student 18,780 Points
Posted by Will Macleod
Will Macleod
Courses Plus Student 18,780 Points

Span elements wont show & Button will not work

//problem: hints are shown even when form is valid
//soludtion: hide and show them at appropriate times
var $password = $("#password");
var $confirmPassword = $("#confirm_password");
//Hide hints
$("form span").hide();

function isPasswordValid() {
  return $password.val().length > 8;
}

function arePasswordsMatching () {
  return $password.val() === $confirmPassword.val();
}

function canSubmit() {
  return isPasswordValid() && arePasswordsMatching();
}

function passwordEvent() {
  //Find out if the password is valid
  if(isPasswordValid) {
   //hide hint if valid
    $password.next().hide();
  } else {
    //else show hint
    $password.next().show();
  }
}

function confirmPasswordEvent() {
//find out if password and confirmation match
  if(arePasswordsMatching) {
     //hide hint if match
    $confirmPassword.next().hide();
  } else {
     //else show the hint 
    $confirmPassword.next().show();
  }   
}

function enableSubmitEvent() {
  $("#submit").prop("disabled", !canSubmit());
}

//when event happens on password input
$password.focus(passwordEvent).keyup(passwordEvent).keyup(confirmPasswordEvent).keyup(enableSubmitEvent);

//when event happens on confirmation input
$confirmPassword.focus(confirmPasswordEvent).keyup(confirmPasswordEvent).keyup(enableSubmitEvent);

enableSubmitEvent();

Keep in mind that I have also named an id="submit" in the input element of the index.html

Thanks

huckleberry
huckleberry
14,636 Points
huckleberry
huckleberry
14,636 Points

Can we see your html?

Cheers,

Huck - :sunglasses:

Will Macleod
Will Macleod
Courses Plus Student 18,780 Points
Will Macleod
Will Macleod
Courses Plus Student 18,780 Points

huckleberry , here is my html, sorry for late reply

<!DOCTYPE html>
<html>
<head>
    <title>Sign Up Form</title>
    <link rel="stylesheet" href="css/style.css" type="text/css" media="screen" title="no title" charset="utf-8">
</head>
<body>

    <form action="#" method="post">
        <p>
            <label for="username">Username</label>
            <input id="username" name="username" type="text">
        </p>
        <p>
            <label for="password">Password</label>
            <input id="password" name="password" type="password">
            <span>Enter a password longer than 8 characters</span>
        </p>
        <p>
            <label for="confirm_password">Confirm Password</label>
            <input id="confirm_password" name="confirm_password" type="password">
            <span>Please confirm your password</span>
        </p>
        <p>
            <input type="submit" value="SUBMIT" id="submit">
        </p>
    </form>
    <script src="http://code.jquery.com/jquery-1.11.0.min.js" type="text/javascript" charset="utf-8"></script>
    <script src="js/app.js" type="text/javascript" charset="utf-8"></script>
</body>
</html>

1 Answer

Rafael Ferreira
Rafael Ferreira
13,086 Points
Rafael Ferreira
Rafael Ferreira
13,086 Points

You forgot the () when you were calling the functions within the if's statements; Try this:

function passwordEvent() {
  //Find out if the password is valid
  if(isPasswordValid()) { //Here!!!
   //hide hint if valid
    $password.next().hide();
  } else {
    //else show hint
    $password.next().show();
  }
}

function confirmPasswordEvent() {
//find out if password and confirmation match
  if(arePasswordsMatching()) { //Here!!!
     //hide hint if match
    $confirmPassword.next().hide();
  } else {
     //else show the hint 
    $confirmPassword.next().show();
  }   
}

I hope it helps :D