Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Practice Selecting Elements

Igor Pavlenko
Igor Pavlenko
12,925 Points
Posted by Igor Pavlenko
Igor Pavlenko
12,925 Points

stuck on challenge

cant make this work plz help ?

let navigationLinks = document.querySelector('nav');

js/app.js 
let navigationLinks = document.querySelector('nav');
let galleryLinks;
let footerImages;
index.html 
<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8">
    <title>Nick Pettit | Designer</title>
    <link rel="stylesheet" href="css/normalize.css">
    <link href='http://fonts.googleapis.com/css?family=Changa+One|Open+Sans:400italic,700italic,400,700,800' rel='stylesheet' type='text/css'>
    <link rel="stylesheet" href="css/main.css">
    <link rel="stylesheet" href="css/responsive.css">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
  </head>
  <body>
    <header>
      <a href="index.html" id="logo">
        <h1>Nick Pettit</h1>
        <h2>Designer</h2>
      </a>
      <nav>
        <ul class="class">
          <li><a href="index.html" class="selected">Portfolio</a></li>
          <li><a href="about.html">About</a></li>
          <li><a href="contact.html">Contact</a></li>
        </ul>
      </nav>
    </header>
    <div id="wrapper">
      <section>
        <ul id="gallery">
          <li>
            <a href="img/numbers-01.jpg">
              <img src="img/numbers-01.jpg" alt="">
              <p>Experimentation with color and texture.</p>
            </a>
          </li>
          <li>
            <a href="img/numbers-02.jpg">
              <img src="img/numbers-02.jpg" alt="">
              <p>Playing with blending modes in Photoshop.</p>
            </a>
          </li>
        </ul>
      </section>
      <footer>
        <a href="http://twitter.com/nickrp"><img src="img/twitter-wrap.png" alt="Twitter Logo" class="social-icon"></a>
        <a href="http://facebook.com/nickpettit"><img src="img/facebook-wrap.png" alt="Facebook Logo" class="social-icon"></a>
        <p>&copy; 2016 Nick Pettit.</p>
      </footer>
    </div>
  <script src="js/app.js"></script>
  </body>
</html>

4 Answers

Leandro Botella Penalva
Leandro Botella Penalva
17,618 Points
Leandro Botella Penalva
Leandro Botella Penalva
17,618 Points

Hi Igor,

First of all, you need to select all elements so instead of querySelector you should use querySelectorAll because querySelector only select the first matching element. Then, you need to select all links inside the nav tag so the selector you should pass to querySelectorAll should be "nav a" instead of "nav".

All I said results in:

document.querySelectorAll('nav a');
Igor Pavlenko
Igor Pavlenko
12,925 Points
Igor Pavlenko
Igor Pavlenko
12,925 Points

Hi Leonardo

can you please tell me why i cannot use the below to select the same elements ?

document.querySelectorAll('nav li');

thnx!

Leandro Botella Penalva
Leandro Botella Penalva
17,618 Points
Leandro Botella Penalva
Leandro Botella Penalva
17,618 Points

It's Leandro not Leonardo :)

nav li would select the parent of the links instead of the links themselves. If you see the structure of the HTML the "li" element it's the parent of the "a" element (the link). Also, the "a" element has a meaning of hyperlink whilst the "li" element has a meaning of a list item.

To sum up, the "nav li" selector would pick only the list items inside any "nav" element but not the links.

Igor Pavlenko
Igor Pavlenko
12,925 Points
Igor Pavlenko
Igor Pavlenko
12,925 Points

sorry Leandro :)

thanx for explaining, now I got it !