styling CSS /html issue

Question

After making the changes in "style the Portfolio" of "How to Make a Website," specifically, adding in the float, my images are sticking together in the middle and the twitter and facebook images are not where they should be as can me seen here: http://web-h1rfj918w2.treehouse-app.com/

(Website is still very rough--just trying to get the basics at this point; new to this coding thing until about 4 days ago)

Also my html code is lighting up on the closing tags for div section body and html at the bottom. I am including my html code and my css. I cannot figure out what is going on in my code to make it misbehave and could use a second pair of (more experienced) eyes. Thanks!

  <head>
    <meta charset="utf-8">
    <title>James Kalb | Musician</title>
    <link rel="stylesheet" href="css/normalize.css">
    <link href='http://fonts.googleapis.com/css?family=Changa+One|Open+Sans:400italic,700italic,400,700,800' rel='stylesheet' type='text/css'>
    <link rel="stylesheet" href="css/main.css">
  </head>
  <body>
    <header>
      <a href="index.html" id="logo">
        <h1>James Kalb</h1>
        <h2>Musician</h2>
      </a>
      <nav>
        <ul>
          <li><a href="index.html" class="selected">Portfolio</a></li>
          <li><a href="about.html">About</a></li>
          <li><a href="contact.html">Contact</a></li>
        </ul>
      </nav>
     </header>
    <div id="wrapper">
       <section>
         <ul id="gallery">
        <ul>
          <li>
            <a href="img/539620_164806606973342_2025864451_n.jpg">
              <img src="img/539620_164806606973342_2025864451_n.jpg" alt="">
              <p>MP photoshoot May 2012</p>
            </a>
          </li>
          <li>
            <a href="img/316359_2273937166911_191580456_n.jpg">
              <img src="img/316359_2273937166911_191580456_n.jpg" alt="">
              <p>Preparing for a gig with Natertot May 2012</p>
            </a>
          </li>
          <li>
            <a href="img/304639_500734239938403_92876693_n.jpg">
              <img src="img/304639_500734239938403_92876693_n.jpg" alt="">
              <p>The Dix Boys April 2012</p>
            </a>
          </li>
          <li>
            <a href="img/1934297_18413716263_7383_n.jpg">
              <img src="img/1934297_18413716263_7383_n.jpg" alt="">
              <p>Jazz Guitar from Brown High School May 2008</p>
            </a>
          </li>
          <li>
            <a href="img/215401_1751130736963_3973740_n.jpg">
              <img src="img/215401_1751130736963_3973740_n.jpg" alt="">
              <p>Fiddling with Professor Sara Sander's Band May 2012</p>
            </a>
          </li>        
        </ul>
       </section>
       <footer>
         <a href="http://twitter.com/jimmythefiddler"><img src="img/twitter-wrap.png" alt="Twitter Logo"></a>
         <a href="http://facebook.com/james.kalb.5"><img src="img/facebook-wrap.png" alt="Facebook Logo"></a>
        <p>&copy; 2014 James Kalb.</p>
       </footer>
     </div>
   </body>
  </html>
</p>```

```<p>/*******************************
GENERAL
*******************************/

body {
  font-family: 'Open Sans', sans-serif;
}

#wrapper {
  max-width: 940px;
  margin: 0 auto;
  padding: 0 5%;
}

a {
text-decoration: none;
}

img {
  max-width: 100%
}
/*******************************
Heading
*******************************/


#logo {
  text-align: center;
  margin: 0;
}

h1 {
  font-family: 'Changa One', sans-serif;
  margin: 15px 0;
  font-size: 1.75em;
  font-weight: normal;
  line-height: 0.8em;

}

h2 {
  font-size: .75em;
  margin: -5px 0 0:
  font-weight: normal;

}


/*******************************
Navigation
*******************************/

nav {
  text-align: center;
  padding: 10px 0;
  margin: 20px 0 0;
}



/*******************************
Footer
*******************************/

footer {
  font-size: .75em;
  text-align: center;
  padding-top: 50px
    color: #ccc;
}



/*******************************
PAGE: Portfolio
*******************************/

# gallery {
  margin: 0;
  padding: 0;
  list-style: none;
}

#gallery li {
  float: left;
  width: 45%;
  margin: 2.5%
  background-color: #f5f5f5;
  color: #bdc3c7;
}


/*******************************
Colors
*******************************/

/* site body */
body {
  background-color: #fff;
  color: #999;
}

/* green header */
header {
  background: #006600;
  border-color: #599a68;
}

/* nav background on mobile */
nav {
  background: #009933;
}

/* logo text */
h1, h2 {
  color: #fff;
}

/* links */
a {
  color: #0000FF;
}

 /* nav link */
nav a, nav a:visited {
  color: #fff;
}

/* selected nav link */
nav a.selected, nav a:hover {
  color: #FF6600;
}
<p>

Answer 1 · 2014-08-01T01:05:05Z

August 1, 2014 1:05am

/********************************
GENERAL
********************************/


body {
  font-family: 'Open Sans', sans-serif;
  background-image: url('../img/congruent_pentagon.png');
}

#wrapper {
  max-width: 940px;
  margin:0 auto;
  padding:0 5%;
}

a {
  text-decoration:none; 
}

img {
  max-width: 100%; 
}

h3 {
  margin: 0 0 1em 0; 
}



/********************************
HEADING
********************************/



header {
  float: left;
  margin: 0 0 30px 0;
  padding: 5px 0 0 0;
  width: 100%;
}

#logo {
  text-align: center;
  margin: 0;
}

h1 {
  font-family: 'Changa One', sans-serif; 
  margin: 15px 0;
  font-size: 1.75em;
  font-weight: normal;
  line-height: 0.8em;
}

h2 {
  font-size:0.75em;
  margin: -5px 0 0;
  font-weight: normal;
}



/********************************
NAVAGATION
********************************/



nav {
  text-align: center;
  padding:10px 0;
  margin: 20px 0 0;
}

nav ul {
  list-style: none;
  margin: 0 10px;
  padding: 0;
}

nav li {
  display: inline-block;
}

nav a {
  font-weight: 800;
  padding: 15px 10px;
}



/********************************
FOOTER
********************************/



footer {
  font-size: 0.75em;
  text-align: center;
  padding-top: 50px;
  color: darkgrey;
  clear: both;
}

.social-icon {
  width: 20px;
  height: 20px;
  margin: 0 5px;
}


/********************************
PAGE PORTFOLIO
********************************/



#gallery {
  margin: 0;
  padding: 0;
  list-style: none;
}

#gallery li {
  float: left;
  width: 45%;
  margin: 2.5%;
  background-color: #f5f5f5;
  color: #bdc3c7;
}

#gallery li a p {
  margin: 0;
  padding: 5%;
  font-size: 0.75em;
  color: darkgrey;
}






/********************************
PAGE: ABOUT
********************************/



.profile-photo {
  display: block;
  max-width: 150px;
  margin: 0 auto 30px;
  border-radius: 100%;
}





/********************************
PAGE: CONTACT
********************************/



.contact-info {
  list-style: none;
  padding: 0;
  margin: 0;
  font-size:0.9em;
}

.contact-info a {
  display: block;
  min-height: 20px;
  background-repeat: no-repeat;
  background-size: 20px 20px;
  padding: 0 0 0 30px;
  margin: 0 0 10px;
}

.contact-info li.phone a {
   background-image: url('../img/phone.png');
}

.contact-info li.mail a {
   background-image: url('../img/mail.png');
}

.contact-info li.twitter a {
   background-image: url('../img/twitter.png');
}



/********************************
COLORS
********************************/



/* site body */
body {
  background-color: #fff;
  color: #999;
}

/* green header */
header {
  background: #6ab47b;
  border-color: #599a68;  
}

/* nav background on mobile */
nav {
  background: #599a68; 
}

/* logo text */
h1, h2 {
  color: #fff; 
}

a {
  color: #6ab47b; 
}

/* nav link */
nav a, nav a:visited {
  color: #fff; 
}

/* selected nav link */
nav a.selected, nav a:hover {
  color: #32673f; 
}

<!DOCTYPE html>
<html>
<head>
  <meta charset = "UTF-8">
  <title>idan ben yair | web designer</title>
  <link href="css/normalize.css" rel="stylesheet" type="text/css">
  <link href='http://fonts.googleapis.com/css?family=Open+Sans:400italic,700italic,400,700,800|Changa+One' rel='stylesheet' type='text/css'>
  <link href="css/main.css" rel="stylesheet" type="text/css">
  <link href="css/responsive.css" rel="stylesheet" type="text/css">
  <meta name = "viewport" content = "width", "device-width, initial-scale=1.0">

</head>
<body>
  <header>
    <a href = "index.html" id = "logo">
  <h1>Idan Ben Yair</h1>
  <h2>Web Designer</h2>
      </a>
    <nav>
    <ul>
      <li>
      <a href = "index.html" class = "selected">PORTFOLIO</a>
      </li>
       <li>
      <a href = "about.html">ABOUT</a>
      </li>
      <li>
      <a href = "contact.html">CONTACT</a>
      </li>

      </ul>
    </nav>
  </header>
  <div id = "wrapper">
    <section>
    <ul id = "gallery">
      <li>
        <a href = "img/numbers-01.jpg">
        <img src = "img/numbers-01.jpg" alt = "">
        <p>Eperimentation with color and texture</p>
        </a>      
      </li>
      <li>
        <a href = "img/numbers-02.jpg">
        <img src = "img/numbers-02.jpg" alt = "">
        <p>Playing with blending modes in photoshop</p>
        </a>      
      </li>
      <li>
        <a href = "img/numbers-06.jpg">
        <img src = "img/numbers-06.jpg" alt = "">
        <p>Trying to create an 80's style of glows.</p>
        </a>      
      </li>
      <li>
        <a href = "img/numbers-09.jpg">
        <img src = "img/numbers-09.jpg" alt = "">
        <p>Eperimentation with color and texture</p>
        </a>      
      </li>
      <li>
        <a href = "img/numbers-12.jpg">
        <img src = "img/numbers-12.jpg" alt = "">
        <p>Eperimentation with color and texture</p>
        </a>      
      </li> 
      <li>
        <a href="http://referrals.trhou.se/idanbenyair" target="_blank"><img src="http://wac.a8b5.edgecastcdn.net/80A8B5/static-assets/assets/content/referral-badge-green.png"/>
<p>Support Treehouse</p>
</a>

      </li>   
      </ul>
    </section>
    <footer>
      <a href = "http://www.twitter.com/idan4all">
      <img src = "img/twitter-wrap.png" alt = "Twitter Logo" class = "social-icon">
      </a>
      <a href = "http://www.facebook.com/idan4all">
        <img src = "img/facebook-wrap.png" alt = "Facebook Logo" class = "social-icon">
        </a>

      <p>&copy; 2014 Idan Ben Yair</p> 

    </footer>
</div>
</body>
</html>

Answer 2 · 2014-08-01T02:25:10Z

August 1, 2014 2:25am

thank you. figured out the issue was I was missing a ; after one of my sections in CSS. now everything is functioning properly but it is still lighting up a couple of elements at the end of my html...

Welcome to the Treehouse Community

Looking to learn something new?

James Kalb

James Kalb

styling CSS /html issue

James Kalb

James Kalb

James Kalb

James Kalb

2 Answers

idan ben yair

idan ben yair

James Kalb

James Kalb