Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trial
Martin Safar
Front End Web Development Techdegree Graduate 30,972 PointsTechdegree Project 5 Download - missing/typos/problems
Hello, I noticed a few missing/typos/problem related things in the ZIP Download files:
In the HTML list of classes we can use for this project there's one called ".form__legend" for styling FORMS but the class is not applied to any HTML element - what am I missing? :D
also for images there are classes starting with "image_" in the list of classes in HTML while the HTML elements use a class starting with "image--" which looks like a simple typo and there's no problem using the "image--" but I'm not sure what to do with the missing ".form_legend" class
Most importantly there seeems to be a typo on line 129 (before BUTTONS) - there's a class called .grid_row--12 and based on the fact that everywhere else in the HTML there's a class called .gridrow only and it's not in the list of classes we can use, I suppose it's a typo and should be just .grid_row
One more thing - there's a class called .theme__colors which is not in the list of classes we can use - is it supposed to be like that? (wondering why the class would be there if we couldn't use it)
I'm sorry for a long post but I'm having a lot of fun doing all the Extra Credits and keep the "Exceeds" spree alive so I thought I'd make sure that I'm not missing anything ;)
anyone else experienced this problem? :)
1 Answer
Nicolas Hampton
44,638 PointsMartin,
There's a couple typos in the top list, so thanks for catching those. I'll make some small adjustment to the project files, but the important thing to remember here is to use the classes in the html. If you do that, nothing I change in the project files will affect either version, but will just make the instructions clearer, as the list of classes at the top was just added as a convenience. Point by point:
You're right,
.form__legenddoesn't exist in the html, but as long as you've made.headline--secondaryeverything should look exactly the same. I'll remove.form__legendfrom the list.There's a small typo regarding
img__. Useimg--as is used in the html. the images have modifiers such asavatarandframe, and these make more sense as "modifiers of elements" rather than as "elements of blocks" in terms of BEM syntax. I'll change these in the list, but it's correct in the html.Yes, this only needs to be
.grid__row, not.grid__row--12, as the rows don't have size modifiers. Depending on how you're selecting your elements in the sass, this might affect you, and it's the only html change I'm making..theme__colorsis used in two categories of this list, the grid and the buttons. Just be aware of that, as I think that's why it wasn't added. I'll add this class to both convenience lists.
Martin Safar
Front End Web Development Techdegree Graduate 30,972 PointsMartin Safar
Front End Web Development Techdegree Graduate 30,972 PointsThank you so much for your clear and detailed answers! I thought we could only use the classes listed at the top of HTML and mentioned in the instructions and now based on your answers we can use all the classes provided in the HTML and it all makes sense now. I really wanted to make sure as one of the requierements is not making any changes to the HTML file. Thank you very much :)