Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

Android Android Activity Lifecycle The Activity Lifecycle Retrieving Instance State

Kevin Grifo
Kevin Grifo
9,824 Points

The background color and text keeps on getting refreshed to the default values and not the saved values.

When I click the show another fact button a couple of times and then change the orientation of my device, the background color, and fact text continue to change to the default values of green and the ant fact. I'm using a newer version of Android studio, so I believe this may be the problem. I'm assuming that the onRestoreInstanceState and onSavedInstanceState methods are implemented differently or maybe it is the type of device i'm using as well. Any help would truly be appreciated. Please view my FunFactsActivity code below which I downloaded from the github link in this course.

package com.teamtreehouse.funfacts;

import android.app.Activity; import android.graphics.Color; import android.os.Bundle; import android.util.Log; import android.view.View; import android.widget.Button; import android.widget.RelativeLayout; import android.widget.TextView;

public class FunFactsActivity extends Activity {

private TextView mFactLabel;
private Button mShowFactButton;
private RelativeLayout mRelativeLayout;
private static final String KEY_FACT = "KEY_FACT";
private static final String KEY_COLOR = "KEY_COLOR";
private FactBook mFactBook = new FactBook();
private ColorWheel mColorWheel = new ColorWheel();
private String mFact = mFactBook.mFacts[0];
private int mColor = Color.parseColor(mColorWheel.mColors[8]);


@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_fun_facts);

    // Assign the views from the layout file to the corresponding variables
    mFactLabel = (TextView) findViewById(R.id.factTextView);
    mShowFactButton = (Button) findViewById(R.id.showFactButton);
    mRelativeLayout = (RelativeLayout) findViewById(R.id.relativeLayout);

    View.OnClickListener listener = new View.OnClickListener() {
        @Override
        public void onClick(View v) {
            String mFact = mFactBook.getFact();

            //update the screen with our new fact.
            mFactLabel.setText(mFact);

            int mColor = mColorWheel.getColor();
            mRelativeLayout.setBackgroundColor(mColor);
            mShowFactButton.setTextColor(mColor);
        }
    };
    mShowFactButton.setOnClickListener(listener);

    //Toast.makeText(this, "Yay! Our Activity was created", Toast.LENGTH_SHORT).show();
    //Log.d(TAG, "We're logging from the onCreate() method!");
}

@Override
protected void onSaveInstanceState(Bundle outState) {
    super.onSaveInstanceState(outState);

    outState.putString(KEY_FACT, mFact);
    outState.putInt(KEY_COLOR, mColor);
}

@Override
protected void onRestoreInstanceState(Bundle savedInstanceState) {
    super.onRestoreInstanceState(savedInstanceState);

    mFact = savedInstanceState.getString(KEY_FACT);
    mFactLabel.setText(mFact);

    mColor = savedInstanceState.getInt(KEY_COLOR);

    mRelativeLayout.setBackgroundColor(mColor);
    mShowFactButton.setTextColor(mColor);
}

}

Thank you in advance.

1 Answer

Seth Kroger
Seth Kroger
56,405 Points

I want to draw your attention to something in the OnClickListener:

@Override
public void onClick(View v) {
    String mFact = mFactBook.getFact();  // <- you are declaring a new string variable here

    //update the screen with our new fact.
    mFactLabel.setText(mFact);

    int mColor = mColorWheel.getColor(); // <- you are declaring a new int variable here
    mRelativeLayout.setBackgroundColor(mColor);
    mShowFactButton.setTextColor(mColor);
}

Both these new variables are only local to onClick() and are not the member variables of the same names, so their values aren't stored.

Kevin Grifo
Kevin Grifo
9,824 Points

I can't believe I didn't catch that. That was my problem, thank you kind sir.