Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

JavaScript JavaScript Basics (Retired) Creating Reusable Code with Functions Create a max() Function

Posted by John White
John White
7,101 Points

The 'max' function isn't rendering a number

I'm trying to figure out why my function isn't rendering

x = max(2, 5);

function max(a, b) { if (b > a) { return max; } else { return false; } };

Thanks,

John

script.js 
x = max(2, 5);

function max(a, b) {
  if (b > a) {
    return max;
  } else {
    return false;
  }
};

2 Answers

doesitmatter
doesitmatter
12,884 Points
doesitmatter
doesitmatter
12,884 Points 
var x = max(2, 5);

function max(a, b) {
  if (b > a) {
    return b;
  } else {
    return a;
  }
};

this returns the maximum value out of a and b, your method doesnt work because it was returning the function itself if b > a and false otherwise

Ivan Bagaric
PLUS
Ivan Bagaric
Courses Plus Student 12,356 Points
Ivan Bagaric
Ivan Bagaric
Courses Plus Student 12,356 Points 
function max(a, b) {
  return (a > b) ? a : b;
}

var x = max(2, 5);
doesitmatter
doesitmatter
12,884 Points

don't think a beginner should use the conditional (ternary) operator yet, but it is the shortest solution

Ivan Bagaric
Ivan Bagaric
Courses Plus Student 12,356 Points

Oh ye, you are right..

then it should be as you post:

function max(a, b) {
   if (a > b) return a;
   else return b;
}