This function should remove all of the vowels ("a", "e", "i", "o", and "u") from the "word"(function's parameter). True?

Question

def disemvowel(word):
    w = word
    vl = ['a','e','i','o','u']
    vu = ['A','E','I','O','U']
    lw = list(w)
    def newword():
        for r in lw:
            if r in vl or r in vu:
                now = True
                lw.remove(r)
                newword()
            elif r not in vl or r not in vu:
                now = False
    new_word()
    novowels = ''.join(lw)
    print(novowels)
disemvowel(word)
disemvowel.py
def disemvowel(word):
    w = word
    vl = ['a','e','i','o','u']
    vu = ['A','E','I','O','U']
    lw = list(w)
    def new_word():
        for r in lw:
            if r in vl or r in vu:
                now = True
                lw.remove(r)
                new_word()
            elif r not in vl or r not in vu:
                now = False
    new_word()
    novowels = ''.join(lw)
    print(novowels)
disemvowel(word)

Antonio De Rose · Accepted Answer

Whilst I agree with Steven, that your approach is correct, I'd still try to keep the code
simple, the need of 2 functions is redundant, as you could do it in 1 function
checking the vowels in a list, make it one list,
true false checking not necessary
and the lines of code, becomes very less, and the code becomes efficient
```python
def disemvowel(word):
    word = list(word)
    lis = ['a','e','i','o','u','A','E','I','O','U']
    li = []
    for w in word:
        if w not in lis:
            li.append(w)
            word = ''.join(li)
    return word

Robert Schaap · Answer

Or something like this, using the try-except method Kenneth mentioned:
```python
def disemvowel(word):
    word = list(word)
    vowels = ["a","e","i","o","u","A","E","I","O","U"]
for vowel in vowels:
    while vowel in word:
        try:
            word.remove(vowel)
        except ValueError:
            pass

return "".join(word)
```

Steven Parker · Answer

You have the right idea, but the function should return the modified word
It doesn't need to "print" anything, and you don't need to call it yourself (the validator will do that).
Also, while it works, it's not a normal programming practice to define a function ("new_word") that is used only once.  Also, the variable "now" is assigned (twice) but never used.
I'll bet you can get it now without an explicit code spoiler.

Welcome to the Treehouse Community

Looking to learn something new?

Pedro Meio-Dia

Pedro Meio-Dia

This function should remove all of the vowels ("a", "e", "i", "o", and "u") from the "word"(function's parameter). True?

3 Answers

Antonio De Rose

Antonio De Rose

Pedro Meio-Dia

Pedro Meio-Dia

Steven Parker

Steven Parker

Pedro Meio-Dia

Pedro Meio-Dia

Robert Schaap

Robert Schaap