Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Selecting Multiple Elements

Gavin Eyquem
seal-mask
.a{fill-rule:evenodd;}techdegree
Gavin Eyquem
Front End Web Development Techdegree Student 19,065 Points
Posted by Gavin Eyquem
.a{fill-rule:evenodd;}techdegree
Gavin Eyquem
Front End Web Development Techdegree Student 19,065 Points

This is my code, so far, var listItems = document.getElementsByTagName('ul'); all the items go red, help?

My code being var listItems = document.getElementsByTagName('ul'); sets the list items to red but not to the different colours as its supposed to.

Where am I going wrong?

js/app.js 
var listItems = document.getElementsByTagName('ul');
var colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];

for(var i = 0; i < colors.length; i ++) {
  listItems[i].style.color = colors[i];    
}
index.html 
<!DOCTYPE html>
<html>
  <head>
    <title>Rainbow!</title>
  </head>
  <body>
    <ul id="rainbow">
      <li>This should be red</li>
      <li>This should be orange</li>
      <li>This should be yellow</li>
      <li>This should be green</li>
      <li>This should be blue</li>
      <li>This should be indigo</li>
      <li>This should be violet</li>
    </ul>
    <script src="js/app.js"></script>
  </body>
</html>
realedwardleung
realedwardleung
7,197 Points

hi,

the Tagname should be 'li' instead of 'ul'

2 Answers

R S
R S
2,255 Points
R S
R S
2,255 Points

You are getting the whole unordered list. Try getting the list items.

realedwardleung
realedwardleung
7,197 Points

it's okay, happy coding :)