Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Object-Oriented JavaScript (2015) Constructor Functions and Prototypes Making the UI Work

this.songs[i].toHTML not a function

I know someone else asked this, but I didn't really see an answer. Below is my code:

playlist.js

function Playlist() {
  this.songs = [];
  this.nowPlayingIndex = 0;

}

Playlist.prototype.add = function(song) {
  this.songs.push(song);
};

Playlist.prototype.play = function() {
  var currentSong = this.songs[this.nowPlayingIndex];
  currentSong.play();
};

Playlist.prototype.stop = function(){
  var currentSong = this.songs[this.nowPlayingIndex];
  currentSong.stop();
};

Playlist.prototype.next = function() {
  this.stop();
  this.nowPlayingIndex++;
  if(this.nowPlayingIndex === this.songs.length){
    this.nowPlayingIndex = 0;
  }
  this.play();
};

Playlist.prototype.renderInElement = function(list) {
  list.innerHTML = "";
  for(var i=0; i<this.songs.length; i++){
    list.innerHTML += this.songs[i].toHTML();
  }
};

song.js

function Song(title, artist, duration) {
  this.title = title;
  this.artist = artist;
  this.duration = duration;
  this.isPlaying = false;
}

Song.prototype.play = function() {
  this. isPlaying = true;
};

Song.prototype.stop = function() {
  this.isPlaying = false;
};

Song.prototype.toHTML = function() {
  var htmlString = '<li';
  if(this.isPlaying){
    htmlString += ' class="current"';
  }
  htmlString += '>';
  htmlString += this.title;
  htmlString += '-';
  htmlString += this.artist;
  htmlString += '<span class="duration">';
  htmlString += this.duration;
  htmlString += '</span></li>';

  return htmlString;
};

app.js

var playlist = new Playlist();

var goodnightIrene = ("Goodnight Irene", "Hank Williams", "2:32");
var electricFeel = ("Electric Feel", "MGMT", "4:02");

playlist.add(goodnightIrene);
playlist.add(electricFeel);

var playlistElement = document.getElementById("playlist");

playlist.renderInElement(playlistElement);

any help is appreciated. Thanks!

2 Answers

Well you know that toHTML is very much a function on the Song object, so there error should be a hint that your function is not finding any Song objects, so:

In your app.js file, make sure to call your Song constructor class, you've just got the arguments floating out there without

new Song(...);

Grr, hidden in plain sight!

Thanks so much, Dan.