Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

JavaScript

Todo app not displaying text of new todo items

See below.

When I click add task, it does not import any of the new text to the added task.

Any ideas on how to fix this one?

//Problem: User interaction doesn't provide desired results
//Solution: Add interactivity so the user can manage daily tasks

var taskInput = document.getElementById("new-task"); //New task
var addButton = document.getElementsByTagName("button")[0]; //First button
var incompleteTasksHolder = document.getElementById("incomplete-tasks"); //#incomplete-tasks
var completedTasksHolder = document.getElementById("completed-tasks"); //#completed-tasks

//New Task List Item
var createNewTaskElement = function(taskstring){
    //Create List Item
    var listItem = document.createElement("li");
    //input checkbox
    var checkBox = document.createElement("input"); //checkbox
    //label
    var label = document.createElement("label"); //label
    //input text
    var editInput = document.createElement("input"); //text
    //button.edit
    var editButton = document.createElement("button"); //edit
    //buton.delete
    var deleteButton = document.createElement("button"); //delete
    //Each element needs to be modified

  checkBox.type = "checkbox";
  editInput.type = "text";

  editButton.innerText = "Edit";
  editButton.className = "edit";
  deleteButton.innerText = "Delete";
  deleteButton.className = "delete";



    //Each element needs to be appended
  listItem.appendChild(checkBox);
  listItem.appendChild(label);
  listItem.appendChild(editInput);
  listItem.appendChild(editButton);
  listItem.appendChild(deleteButton);

  return listItem;
}

//Add a new task
var addTask = function(){
  console.log("Add task...");

  //When the button is pressed
  //Create a new list item with the text from the #new-task:
  var listItem = createNewTaskElement(taskInput.value);
  //Append listItem to incompleteTasksHolder
  incompleteTasksHolder.appendChild(listItem);
  bindTaskEvents(listItem, taskCompleted);
}
//Edit an existing task
var editTask = function(){
    console.log("Edit  task...");
  var listItem = this.parentNode;
  var editInput = listItem.querySelector("input[type=text]");
    //If the class of the parent is .editMode
      //Switch from .editMode
      //label text become the input's value
    //else
      //Switch to .editMode
      //input value becomes to label's text
    //Toggle .editMode
}
//Delete an existing task
var deleteTask = function(){
    console.log("Delete task...");
  //When the delete button is pressed
  var listItem = this.parentNode;
  var ul = listItem.parentNode;
  //Remove the parent list item from the ul
  ul.removeChild(listItem);
}    

//Mark a task as complete
var taskCompleted = function(){
  console.log("Complete task...");
    //Append the task list item to the #completed-tasks
  var listItem = this.parentNode;
  completedTasksHolder.appendChild(listItem);
  bindTaskEvents(listItem, taskinComplete);
}

//Mark a task as incomplete
var taskinComplete = function(){
  console.log("Task incomplete...");
  //Append the task list item to the #incomplete-tasks
  var listItem = this.parentNode;
  incompleteTasksHolder.appendChild(listItem);
  bindTaskEvents(listItem, taskCompleted);
}


//Set the click handler to the addTask function
addButton.onclick = addTask;

var bindTaskEvents = function(taskListItem, checkboxEventHandler){
  console.log("Bind list item events");
  //select taskListItem's children
  var checkbox = taskListItem.querySelector("input[type=checkbox]");
  var editButton = taskListItem.querySelector("button.edit");
  var deleteButton = taskListItem.querySelector("button.delete");
    //bind editTask to edit button
  editButton.onclick = editTask;
    //bind deleteTask to delete button
  deleteButton.onclick = deleteTask;
    //bind taskCompleted to checkbox
  checkbox.onchange = checkboxEventHandler;
}

//cycle over incompleteTasksHolder ul list items
for(var i = 0; i < incompleteTasksHolder.children.length; i++){
  //bind events to list items children (taskCompleted)
  bindTaskEvents(incompleteTasksHolder.children[i], taskCompleted);
}

//cycle over TasksHolder ul list items
for(var i = 0; i < completedTasksHolder.children.length; i++){
  //bind events to list items children (taskIncomplete)
  bindTaskEvents(completedTasksHolder.children[i], taskinComplete);
}

1 Answer

Hey Eric,

I'm not sure what you mean that it doesn't add any of the new text to the added task. Do you mean that it's not adding the text you put into the input box to the new task or that it's not adding the "Edit" and "Delete" buttons to the new task when you create it? I tested your code and what's in there works fine. Can you be more specific?