Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Build a Simple Dynamic Site with Node.js Creating a Basic Template Engine in Node.js A Simple Merge Utility

Posted by barnetobeka
barnetobeka
Courses Plus Student 10,895 Points

Tried using the replace method but totally failed to work

its as if the replace object its not recognised
index.js 
var utilities = require("./utilities");
var fs = require("fs");

var mailValues = {};

mailValues.first_name = "Janet";

var emailTemplate = fs.readFile("Hi %first_name%! Thanks for completing this code challenge :)");

var mergedContent = utilities.merge(emailTemplate, mailValues);

//mergedContent === "Hi Janet! Thanks for completing this code challenge :)";
utilities.js 
function merge(content, values) {
  for(let key in values){
    content =  content.replace("{{"+ key +"}}",values[key]);
  }
  return content
}


module.exports.merge = merge;

2 Answers

Steven Parker
Steven Parker
229,732 Points
Steven Parker
Steven Parker
229,732 Points

Your content argument may be undefined or null.

I notice you're passing the return value from fs.readFile to your merge method, but I don't think it actually returns anything. I would also expect it to need different arguments.

Please take a look at the documentation page covering fs.readFile for proper usage information. I might also be that you intended to do something else there entirely.

Mark Warren
Mark Warren
19,252 Points
Mark Warren
Mark Warren
19,252 Points

It's pretty similar to the function in renderer.js, except in this case the value you're replacing is wrapped with %..% instead of {{...}}

function merge(content, values) {
  for (let key in values) {
    content = content.replace("%" + key + "%", values[key]);
  }
  return content;
}

module.exports.merge = merge;