Trying to build Constructor Dice game

Question

I am trying to go above and beyond and build a dice game from the previous lessons in this bunch. Below is my code with each file name labeled above. Not sure if my files will show correctly since I used Sublime text to do this project on my own

// dice.js file
//used a constructor function to substitute the object literal instead.

function dice(sides){

  this.sides = sides;

  this.roll = function() {
    return Math.floor(Math.random() * this.sides) + 1; 

  }

}

var dice6 = new dice(6);

dice6.roll();

// ui.js file

function printNumber(number) {
  var placeholder = document.getElementById("placeholder");
  placeholder.innerHTML = number;
}

var button = document.getElementById("button");



button.onclick = function() {

  var result = dice6.roll(); // I changed this here to reference my constructor object, keep on getting 'undefined' in the console. Not sure why, any ideas?
  printNumber(result);
};

// index.html file

<html>
<head>
    <title>Dice Simulator 2015</title>
    <link rel="stylesheet" href="style.css">
</head>  
<body>
  <p id="placeholder">

  </p>
  <button id="button">Roll Dice</button>
  <script src="dice_constructor_function.js"></script>
  <script src="ui.js"></script>
</body>
</html>

Answer 1 · 2017-07-26T15:03:34Z

July 26, 2017 3:03pm

Your script seems perfect to me and it works well. However, according to the file name you have mentioned in top of each file, you should call the script in html as:

Welcome to the Treehouse Community

Looking to learn something new?

Greg Schudel

Greg Schudel

Trying to build Constructor Dice game

1 Answer

Bibek Shakya

Bibek Shakya