Trying to modify the code - is it an endless loop?

Question

Hi everyone,
I would like to ask your for asistance with the code below. I have modified it a bit to have a user input instead of computer vs. computer guessing the random number, but it seems that I made a mistake somewhere as I cannot get the loop end. Could you please help? 
var randomNo = randomNumber();
var guess = guessNumber()
var attempts = 0;
function randomNumber() {
var numberGenerated = Math.floor( Math.random() * 6 ) + 1;
return numberGenerated
}
function guessNumber() {
var question = parseInt(prompt("Gusss a random number from 1 to 6 generated by the application."));
return question
}
while( guess !== randomNo )
{
    guessNumber()
    attempts += 1;
}
document.write("The random number was " + randomNo + "." );
document.write("The number of attempts was " + attempts + ".");
Thank you, 
Ewa

Joel Bardsley · Accepted Answer

Hi Ewa,
You've assigned the guess variable at the start but you're not updating its value each time the guessNumber() function is executed, causing the infinite while loop. To fix this, you could update the guessNumber() function as follows:
```js
function guessNumber() {
// Replace the newly created 'question' variable with the existing guess variable
guess = parseInt(prompt("Gusss a random number from 1 to 6 generated by the application."));
// Return the updated value of guess based on the user's input:
return guess;
}
```
Hope that helps.

Welcome to the Treehouse Community

Looking to learn something new?

Ewa Czech

Ewa Czech

Trying to modify the code - is it an endless loop?

1 Answer

Joel Bardsley

Joel Bardsley

Ewa Czech

Ewa Czech