undefined method `user_friendships' for nil:NilClass – Creating the Friendship

require 'test_helper'

class UserFriendshipsControllerTest < ActionController::TestCase
    context "#new" do
        context "when not logged in" do
            should "redirect to the login page" do
                get :new
                assert_response :redirect
                assert_redirected_to login_path
            end
        end

        context "when logged in" do
            setup do
                sign_in users(:ian)
            end

            should "get new and return success" do
                get :new
                assert_response :success
            end

            should "should set a flash error if the friend_id params is massing" do
                get :new, {}
                assert_equal "Friend required", flash[:error]
            end

            should "display the friend's name" do
                get :new, friend_id: users(:mike)
                assert_match /#{users(:mike).full_name}/, response.body

            end

            should "assign a new user friendship" do
                get :new, friend_id: users(:mike)
                assert assigns(:user_friendship)
            end

            should "assign a new user friendship to the correct friend" do
                get :new, friend_id: users(:mike)
                assert_equal users(:mike), assigns(:user_friendship).friend
            end

            should "assign a new user friendship to the currently logged in user" do
                get :new, friend_id: users(:mike)
                assert_equal users(:ian), assigns(:user_friendship).user
            end

            should "returns a 404 status if no friend is found" do
                get :new, friend_id: 'invalid'
                assert_response :not_found
            end

            should "ask if you really want to friend the user" do
                get :new, friend_id: users(:mike)
                assert_match /Do you really want to friend #{users(:mike).full_name}?/, response.body
            end
        end
    end

    context "#create" do
        context "when not logged in" do
            should "redirect to the login page" do
                get :new
                assert_response :redirect
                assert_redirected_to login_path
            end
        end

        context "when logged in" do
            setup do
                sign_in(:ian)
            end

            context "with no friend_id" do
                setup do
                    post :create
                end

                should "set the flash error message" do
                    assert !flash[:error].empty?
                end

                should "redirect to the site root" do
                    assert_redirected_to root_path
                end
            end

            context "with a valid friend_id" do
                setup do
                    post :create, friend_id: users(:mike)
                end

                should "assign a friend object" do
                    assert assigns(:friend)
                end

                should "assign a user_friendship object" do
                    assert assigns(:user_friendship)
                end
            end
        end
    end
end

class UserFriendshipsController < ApplicationController
    before_filter :authenticate_user!, only: [:new]

    def new
        if params[:friend_id]
            @friend = User.where(profile_name: params[:friend_id]).first
            raise ActiveRecord::RecordNotFound if @friend.nil?
            @user_friendship = current_user.user_friendships.new(friend: @friend)
        else
            flash[:error] = "Friend required"
        end
    rescue ActiveRecord::RecordNotFound
        render file: 'public/404', status: :not_found
    end

    def create
        if params[:friend_id]
            @friend = User.where(profile_name: params[:friend_id]).first
            @user_friendship = current_user.user_friendships.new(friend: @friend)
        else
            flash[:error] = "Friend required"
            redirect_to root_path
        end
    end
end