Using a custom layout as a dialog

Question

I am trying to have a custom layout that I have created open as a dialog when a button on my app is pressed. I already figured out how to have a simple dialog with a title, message and positive button display when the button is pressed, but now I have been trying to change it to the custom layout and the app crashes when the button is pressed. Here are the files. The xml layout is just a rough draft, but the basic components are there.

NewTaskDialogFragment.java:

import android.app.AlertDialog;
import android.app.Dialog;
import android.app.DialogFragment;
import android.content.Context;
import android.content.DialogInterface;
import android.os.Bundle;
import android.view.LayoutInflater;
import android.view.View;


public class NewTaskDialogFragment extends DialogFragment implements
        android.view.View.OnClickListener {

    public Dialog onCreateDialog(Bundle savedInstanceState) {
        Context context = getActivity();
        AlertDialog.Builder builder = new AlertDialog.Builder(context);

        LayoutInflater inflater = LayoutInflater.from(context);
        View dialogView= inflater.inflate(R.layout.new_task_dialog, null);
        builder.setView(dialogView);
        builder.show();

        return builder.create();
}
    @Override
    public void onClick(View view) {

    }
}

new_task_dialog.xml:

<?xml version="1.0" encoding="utf-8"?>
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
              android:orientation="vertical"
              android:layout_width="match_parent"
              android:layout_height="wrap_content"
              android:background="#919191">


    <EditText
        android:layout_width="match_parent"
        android:layout_height="100dp"
        android:inputType="textMultiLine"
        android:ems="10"
        android:id="@+id/editText"
        android:background="#ffffff"
        android:layout_marginTop="20dp"
        android:layout_marginBottom="20dp"
        android:hint="What do you need to get done this week?"
        android:gravity="top"
        />

    <LinearLayout
        android:orientation="horizontal"
        android:layout_width="match_parent"
        android:layout_height="match_parent"
        android:weightSum="2">

        <Spinner
            android:layout_width="match_parent"
            android:layout_height="wrap_content"
            android:id="@+id/spinner2"
            android:layout_weight="1"
            />

        <Spinner
            android:layout_width="match_parent"
            android:layout_height="wrap_content"
            android:id="@+id/spinner"
            android:layout_weight="1"/>
    </LinearLayout>

</LinearLayout>

Relevant parts of MainActivity.java (showTaskOnClick is called in OnCreate):

private void showTaskOnClick(){
        Button addTaskButton = (Button) findViewById(R.id.addTaskButton);
        addTaskButton.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View view) {
               showTaskBox();
            }
        });
    }
    private void showTaskBox(){
        NewTaskDialogFragment dialog = new NewTaskDialogFragment();
        dialog.show(getFragmentManager(), "");
    }

Thanks in advance for the help!

Answer 1 · 2016-11-15T21:23:55Z

November 15, 2016 9:23pm

https://developer.android.com/reference/android/app/AlertDialog.Builder.html says to use create() OR show() but not both since they do the same thing. show() just takes the extra step of displaying the dialog. Since the DialogFragment should take care of showing it, use should use create().

Welcome to the Treehouse Community

Looking to learn something new?

Riley Bolen

Riley Bolen

Using a custom layout as a dialog

1 Answer

Seth Kroger

Seth Kroger

Riley Bolen

Riley Bolen