Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Django ORM Total Control Q

Mirko Xiang Zhao
Mirko Xiang Zhao
17,787 Points
Posted by Mirko Xiang Zhao
Mirko Xiang Zhao
17,787 Points

Using Q in Django ORM challenge

Stuck to this challenge, can't seem to spot what is wrong... Thanks in advance for the help

products/views.py 
import datetime

from django.db.models import Q
from django.shortcuts import render, get_object_or_404

from . import models


def good_reviews(request):
    reviews = models.Review.objects.filter(rating__gte=3)
    return render(request, 'products/reviews.html', {'reviews': reviews})


def recent_reviews(request):
    six_months_ago = datetime.datetime.today() - datetime.timedelta(days=180)
    reviews = models.Review.objects.exclude(created_at__lt=six_months_ago)
    return render(request, 'products/reviews.html', {'reviews': reviews})


def product_detail(request, pk):
    product = get_object_or_404(models.Product, pk=pk)
    four_weeks = datetime.datetime.today() - datetime.timedelta(days=28)
    reviews = product.review_set.filter(
        Q(rating__gte8)|Q(created_at_lt=four_weeks)
    ).order_by('-created_at').all()
    return render(request, 'products/product_detail.html', {'product': product, 'reviews': reviews})

1 Answer

Chris Freeman
MOD
Chris Freeman
Treehouse Moderator 68,454 Points
Chris Freeman
Chris Freeman
Treehouse Moderator 68,454 Points

You are very close. Mostly syntax issues. The comparison to four_weeks needs to be "gte" since newer dates are larger than the four_weeks ago value. Since adding a filter, the trailing ".all()" can be dropped.

def product_detail(request, pk):
    product = get_object_or_404(models.Product, pk=pk)
    four_weeks = datetime.datetime.today() - datetime.timedelta(days=28)
    reviews = product.review_set.filter(
        Q(rating__gte=8) |  # <-- added equal sign before 8 
        Q(created_at__gte=four_weeks) # Changed 'lt' to 'gte'. Added missing underscore before 'gte'
    ).order_by('-created_at')
    return render(request, 'products/product_detail.html', {'product': product, 'reviews': reviews})