Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

Android Android Activity Lifecycle Introducing SharedPreferences Saving and Retrieving Data with SharedPreferences

Kristóf Balajti-Tóth
Kristóf Balajti-Tóth
17,675 Points

Using the setChecked method

Hi! It is my first question. I can not figure it out what is wrong with my code. I got an error "Remember to call setChecked on the CheckBox object", but i think I use the setChecked method correctly. Thank in advance!

All the best, Kristof

MainActivity.java
import android.view.View;
import android.os.Bundle;

public class MainActivity extends Activity {

  public CheckBox mCheckBox;
  public static final String PREFS_FILE = "pref";
  public static final String KEY_CHECKBOX = "check";
  private SharedPreferences mSharedPreferences;
  private SharedPreferences.Editor mEditor;

  @Override
  protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);

    mCheckBox = (CheckBox) findViewById(R.id.checkBox);
    mSharedPreferences = getSharedPreferences(PREFS_FILE, Context.MODE_PRIVATE);
    mEditor = mSharedPreferences.edit();

    if(mSharedPreferences.getBoolean(KEY_CHECKBOX, true)){

     mCheckBox.setChecked(true); 

    }

      if(mSharedPreferences.getBoolean(KEY_CHECKBOX, false)){

     mCheckBox.setChecked(false); 

    }

  }

 @Override
  protected void onPause() {
    super.onPause();

    if(mCheckBox.isChecked()){

    mEditor.putBoolean(KEY_CHECKBOX, mCheckBox.isChecked());
    mEditor.apply();

    } else {

    mEditor.putBoolean(KEY_CHECKBOX, !mCheckBox.isChecked());
    mEditor.apply();

    }
  }
}

1 Answer

Seth Kroger
Seth Kroger
56,407 Points

I think you're over-thinking the code a bit. isChecked() already gives you a value you can put into preferences, so there is no need for the if statements. (Note that putting the same value in if true, but the inverse if false, always puts the value of true into shared prefs.)

 @Override
  protected void onPause() {
    super.onPause();

    mEditor.putBoolean(KEY_CHECKBOX, mCheckBox.isChecked());
    mEditor.apply();
  }
Kristóf Balajti-Tóth
Kristóf Balajti-Tóth
17,675 Points

Thank for your answer. It was very helpful, I managed to solve the test.