Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Loops, Arrays and Objects Simplify Repetitive Tasks with Loops The Refactor Challenge Solution

Hunter Shaw
Hunter Shaw
2,187 Points
Posted by Hunter Shaw
Hunter Shaw
2,187 Points

Was this a bad way of doing the challenge? 

var html = '';
var red;
var green;
var blue;
var rgbColor;

function randomColors(html) {
  red = Math.floor(Math.random() * 256 );
  green = Math.floor(Math.random() * 256 );
  blue = Math.floor(Math.random() * 256 );
  rgbColor = 'rgb(' + red + ',' + green + ',' + blue + ')';
  return html += '<div style="background-color:' + rgbColor + '"></div>';
}


for ( i = 0; i < 10; i += 1) {
  document.write(randomColors(html));
}
Hunter Shaw
Hunter Shaw
2,187 Points
Hunter Shaw
Hunter Shaw
2,187 Points

I'm sorry, I didn't watch until the end of the video. He just suggested doing it this way. I am done. Lmao.

1 Answer

Steven Parker
Steven Parker
229,732 Points
Steven Parker
Steven Parker
229,732 Points

If it works, it's not bad!

But you could make it more "DRY" if you wanted. For example, you could make a function for picking the random values so you don't need to repeat the same code 3 times when picking the colors values.

Hunter Shaw
Hunter Shaw
2,187 Points
Hunter Shaw
Hunter Shaw
2,187 Points

Thank you, you're always oh-so helpful!