Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

General Discussion

Posted by ninyo
ninyo
15,367 Points

Website Critique?

I was hoping to receive some coding critique from fellow classmates/teachers on my finished product and would appreciate some honest feedback and a few suggestions on how to improve it.

A bit of background, I've started this year 2014 January with almost no idea of html css with the hopes to learn how to understand what <table>s are... and little did I know, there was a lot to want to learn! 7 Months total (took a summer off).

http://Nin-yo.com

Situation: I've only integrated html css and php, with only one JQuery plugin. I do want to add in some JavaScript, but I'm still taking it one step at a time. Some things I know is that the Sass output is sloppy as I overused nested css for almost everything (going to change that with version 2), I used brackets for reordering folder hierarchy in the finder window (which i'll change to using just an underscore), and I hope to reconsider layout ideas yet still maintain the design simplicity.

Thank you very much.

—————

The concept I've enjoyed the most was PHP looping from linked multi-level arrays to intermingle with HTML. When I finally grasped that, I was hooked.

2 Answers

Stu Cowley
Stu Cowley
26,287 Points
Stu Cowley
Stu Cowley
26,287 Points

This site looks really cool. Love your work Ninyo :)

Ryan Carson
Ryan Carson
23,287 Points
Ryan Carson
Ryan Carson
23,287 Points

Hi Ninyo

Great work on getting this live. It looks great!

Your markup here seems wrong though:

<div id="wrap_top">
    <div id="lock_top" class="top_main">
        <ul id="navigation">
            <a href="details.php" id="logo" class="content">
                            </li>
        </ul>
        <a href="details.php"><div id="avatar"><div id="shadow_avatar"></div></div></a>
    </div>
</div>

The </li> doesn't have an opening <li>

Stu Cowley
Stu Cowley
26,287 Points

I also noticed too that you have a couple of divs with no content.

<div id="right_side">
    <div id=""></div>
    <div id=""></div>
</div>