Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Selecting Multiple Elements

Heidi S Wolff
Heidi S Wolff
12,757 Points

What am I doing wrong?

I'm not sure what's wrong here.

<!DOCTYPE html>
    <ul id="rainbow">
      <li>This should be red</li>
      <li>This should be orange</li>
      <li>This should be yellow</li>
      <li>This should be green</li>
      <li>This should be blue</li>
      <li>This should be indigo</li>
      <li>This should be violet</li>
    <script src="js/app.js"></script>
let listItems = document.getElementsByTagName('ul');
const colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];

for(var i = 0; i < colors.length; i ++) {
  listItems[i].style.color = colors[i];    

2 Answers

Hi there, you're very close. The challenge is wanting you to select every li with an id of "rainbow", and right now you are using getElementsByTagName on ul, which would select every ul element as a whole in your html.

Instead, use document.querySelectorAll('#rainbow li');

Good luck!

Heidi S Wolff
Heidi S Wolff
12,757 Points

Thank you! I wish the questions were written more clearly.

The instructions can occasionally be a little ambiguous, but the forum is always there for ya. Best of luck!